Log failed twofactor authentication

[pedro-vo]

Description

Log failed twofactor authentication

Related Issue

• Fixes Log failed twofactor authentication #37400

Motivation and Context

Possible log analysis of failed twofactor authentication

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Update test case

Checklist:

• Code changes
• Changelog item, see TEMPLATE

[CLAassistant]

All committers have signed the CLA.

[mmattel]

Please add a changelog, you will find a template here: https://github.com/owncloud/core/tree/master/changelog

[pedro-vo]

Please add a changelog, you will find a template here: https://github.com/owncloud/core/tree/master/changelog

Done.

[phil-davis]

@micbar or ?
who should review this?

[micbar]

LGTM!
@DeepDiver1975 any thoughts?

[karakayasemi]

To be sure that all failed two-factor authentications logged, imho, writing this log from TwoFactorAuthManager is better. Also, commits should be squashed before the merge.

[karakayasemi]

Thank you for your contribution. The code changes look good. There are small problems left.
The base commit is pretty old, I guess that's why Codecov could not calculate the coverage. We need to rebase the branch to the top of the current master. Also, instead of 5 commits, please squash them as 1 meaningful commit when rebasing.
If you need any help, do not hesitate to ping me.

[codecov]

Codecov Report

Merging #37401 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37401   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19339    19339           
=========================================
  Files          1279     1279           
  Lines         75569    75572    +3     
  Branches       1331     1331           
=========================================
+ Hits          48876    48879    +3     
  Misses        26301    26301           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <100.00%> (+<0.01%)	19339.00 <1.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
...b/private/Authentication/TwoFactorAuth/Manager.php	93.61% <100.00%> (+0.43%)	19.00 <1.00> (ø)
lib/private/Server.php	85.18% <100.00%> (ø)	129.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158bd97...2c8a784. Read the comment docs.

[codecov]

Codecov Report

Merging #37401 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37401   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19339    19339           
=========================================
  Files          1279     1279           
  Lines         75569    75572    +3     
  Branches       1331     1331           
=========================================
+ Hits          48876    48879    +3     
  Misses        26301    26301           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <100.00%> (+<0.01%)	19339.00 <1.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
...b/private/Authentication/TwoFactorAuth/Manager.php	93.61% <100.00%> (+0.43%)	19.00 <1.00> (ø)
lib/private/Server.php	85.18% <100.00%> (ø)	129.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158bd97...2c8a784. Read the comment docs.

[codecov]

Codecov Report

Merging #37401 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master   #37401   +/-   ##
=========================================
  Coverage     64.67%   64.67%           
  Complexity    19339    19339           
=========================================
  Files          1279     1279           
  Lines         75569    75573    +4     
  Branches       1331     1331           
=========================================
+ Hits          48876    48880    +4     
  Misses        26301    26301           
  Partials        392      392           

Flag	Coverage Δ	Complexity Δ
#javascript	54.14% <ø> (ø)	0.00 <ø> (ø)
#phpunit	65.84% <100.00%> (+<0.01%)	19339.00 <1.00> (ø)

Impacted Files	Coverage Δ	Complexity Δ
...b/private/Authentication/TwoFactorAuth/Manager.php	93.75% <100.00%> (+0.56%)	19.00 <1.00> (ø)
lib/private/Server.php	85.18% <100.00%> (ø)	129.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 158bd97...a7f67e6. Read the comment docs.

[davitol]

{"reqId":"mfURXZdJK2sIjdi2aPgb","level":2,"time":"2020-07-15T12:23:17+00:00","remoteAddr":"172.24.0.1","user":"admin","app":"core","method":"POST","url":"\/login\/challenge\/totp","message":"Two factor verify failed: 'admin' (Remote IP: '172.24.0.1')"}

That is the log that appears. I guess it is enough info, but just to confirm.