Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump icewind/smb from 3.1.2 to 3.2.3 in /apps/files_external/3rdparty #37370

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented May 11, 2020

Bumps icewind/smb from 3.1.2 to 3.2.3.

Release notes

Sourced from icewind/smb's releases.

3.2.3

  • add proper paths to exceptions during stream close and write

3.2.2

  • Add NetworkResetException
  • Properly close the stream when there is an exception during flush

3.2.1

  • Reduce the number of requests needed to populate the FileInfo object when using libsmbclient-php

3.2.0

  • Throw correct exception when connection is reset
  • Allow getting acls from FileInfo
Commits
  • db50bb5 add proper paths to exceptions during stream close and write
  • b2a6274 handle exceptions during stream close
  • b48dfc0 add network reset error, fix connection reset
  • 5330edc remove unused method
  • 4411326 ignore any errors while trying to send the close command, the process might a...
  • b594f7c use system.dos_attr.* for both mode and stat info
  • 63319ec fix mode parsing for php 7.4
  • 9fb1753 remove debug
  • 742be89 travis fix
  • 444cc1c Revert "Use stat to fetch mode"
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #37370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37370   +/-   ##
=========================================
  Coverage     64.57%   64.57%           
  Complexity    19220    19220           
=========================================
  Files          1268     1268           
  Lines         75105    75105           
  Branches       1331     1331           
=========================================
  Hits          48496    48496           
  Misses        26217    26217           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.72% <ø> (ø) 19220.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3385609...3103290. Read the comment docs.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/apps/files_external/3rdparty/icewind/smb-3.2.3 branch from b63c85c to e3862e9 Compare May 11, 2020 14:40
@phil-davis phil-davis requested a review from VicDeo May 11, 2020 14:48
@owncloud owncloud deleted a comment from update-docs bot May 11, 2020
@phil-davis
Copy link
Contributor

I have added the files that go with icewind/smb 3.2.3 by doing a composer install in apps/files_external/3rdparty in this PR, and added a changelog.

Reviewers, is this all that is needed?

Copy link
Member

@VicDeo VicDeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not tested

@dependabot-preview
Copy link
Contributor Author

A newer version of icewind/smb exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@phil-davis
Copy link
Contributor

Merging this, and then we can see what the bot does next.

@phil-davis phil-davis merged commit e15320d into master May 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/apps/files_external/3rdparty/icewind/smb-3.2.3 branch May 19, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants