Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop writing data to the output buffer in case the connection is no l… #37219

Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 7, 2020

Description

Bugfix: Stop writing data to the output buffer when the connection is not alive

Publicly shared video playback is sending a range http request to get the video
content. In cases where the user is seeking to different positions of the video
will result in a pretty high server load because all the video content is sent
to the browser. Without detecting the connection state on server side all data
is put to the output buffer.
With this change the server processes will stop sending data as soon as the
connection is detected as non-active.

#37219

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Apr 7, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/stop-writing-to-no-longer-alive-connections branch from 99e24d7 to 44946dc Compare April 7, 2020 12:03
@DeepDiver1975 DeepDiver1975 self-assigned this Apr 7, 2020
@codecov
Copy link

codecov bot commented Apr 7, 2020

Codecov Report

Merging #37219 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37219      +/-   ##
============================================
- Coverage     64.87%   64.87%   -0.01%     
- Complexity    19146    19147       +1     
============================================
  Files          1269     1269              
  Lines         74947    74950       +3     
  Branches       1331     1331              
============================================
  Hits          48625    48625              
- Misses        25930    25933       +3     
  Partials        392      392              
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.07% <0.00%> (-0.01%) 19147.00 <2.00> (+1.00) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.42% <0.00%> (-0.42%) 391.00 <2.00> (+2.00) ⬇️
lib/private/legacy/files.php 0.00% <ø> (ø) 66.00 <0.00> (-1.00)
...AppFramework/Utility/ControllerMethodReflector.php 100.00% <0.00%> (ø) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8ae99c...44946dc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants