-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop writing data to the output buffer in case the connection is no l… #37219
Stop writing data to the output buffer in case the connection is no l… #37219
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
99e24d7
to
44946dc
Compare
Codecov Report
@@ Coverage Diff @@
## master #37219 +/- ##
============================================
- Coverage 64.87% 64.87% -0.01%
- Complexity 19146 19147 +1
============================================
Files 1269 1269
Lines 74947 74950 +3
Branches 1331 1331
============================================
Hits 48625 48625
- Misses 25930 25933 +3
Partials 392 392
Continue to review full report at Codecov.
|
Description
Bugfix: Stop writing data to the output buffer when the connection is not alive
Publicly shared video playback is sending a range http request to get the video
content. In cases where the user is seeking to different positions of the video
will result in a pretty high server load because all the video content is sent
to the browser. Without detecting the connection state on server side all data
is put to the output buffer.
With this change the server processes will stop sending data as soon as the
connection is detected as non-active.
#37219
How Has This Been Tested?
Types of changes
Checklist: