Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-only] acceptance tests for sharing with multiple users and groups #36915

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Feb 10, 2020

Description

Adds acceptance test for sharing with users and groups having the same name and changing permissions and expiration date

Related Issue

#36818

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@haribhandari07 haribhandari07 force-pushed the share-permissions branch 2 times, most recently from 1376465 to ec07fde Compare February 10, 2020 05:47
@codecov
Copy link

codecov bot commented Feb 10, 2020

Codecov Report

Merging #36915 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36915      +/-   ##
============================================
+ Coverage     64.49%   64.68%   +0.19%     
  Complexity    19138    19138              
============================================
  Files          1270     1270              
  Lines         74912    74912              
  Branches       1329     1329              
============================================
+ Hits          48313    48460     +147     
+ Misses        26208    26061     -147     
  Partials        391      391              
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0.00 <ø> (ø) ⬆️
#phpunit 65.85% <ø> (+0.21%) 19138.00 <ø> (ø) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/PostgreSqlMigrator.php 0.00% <0.00%> (-100.00%) 4.00% <0.00%> (ø%)
...ilder/ExpressionBuilder/PgSqlExpressionBuilder.php 0.00% <0.00%> (-88.89%) 3.00% <0.00%> (ø%)
lib/private/DB/AdapterPgSql.php 0.00% <0.00%> (-85.72%) 2.00% <0.00%> (ø%)
lib/private/DB/Migrator.php 53.01% <0.00%> (-2.41%) 30.00% <0.00%> (ø%)
lib/private/DB/MDB2SchemaManager.php 87.71% <0.00%> (-1.76%) 17.00% <0.00%> (ø%)
lib/private/legacy/db.php 70.51% <0.00%> (-1.29%) 33.00% <0.00%> (ø%)
lib/private/legacy/util.php 72.57% <0.00%> (-1.03%) 219.00% <0.00%> (ø%)
lib/private/Files/Storage/DAV.php 78.48% <0.00%> (-0.62%) 0.00% <0.00%> (ø%)
apps/dav/lib/CardDAV/CardDavBackend.php 82.31% <0.00%> (-0.23%) 85.00% <0.00%> (ø%)
apps/dav/lib/CalDAV/CalDavBackend.php 80.44% <0.00%> (-0.14%) 169.00% <0.00%> (ø%)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b41d4...32f584f. Read the comment docs.

@haribhandari07 haribhandari07 changed the title acceptance tests for sharing with multiple users and groups [Tests-only] acceptance tests for sharing with multiple users and groups Feb 10, 2020
@haribhandari07 haribhandari07 force-pushed the share-permissions branch 4 times, most recently from 1da08ea to b7d3287 Compare February 11, 2020 04:20
@haribhandari07 haribhandari07 self-assigned this Feb 11, 2020
@haribhandari07 haribhandari07 force-pushed the share-permissions branch 8 times, most recently from 1cdfa99 to 933f4cb Compare February 13, 2020 05:39
@haribhandari07 haribhandari07 marked this pull request as ready for review February 13, 2020 05:40
@haribhandari07 haribhandari07 force-pushed the share-permissions branch 2 times, most recently from 61a4928 to f2aadb5 Compare February 13, 2020 08:48
@haribhandari07 haribhandari07 force-pushed the share-permissions branch 2 times, most recently from 2689e0f to acc3190 Compare February 14, 2020 05:54
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added commits to:

  • do a general rename of $fd in all places to $bodyRows (I don't know what $fd was supposed to stand for somewhere in past history)
  • rename toggleShareActions to openShareActionsIfNotOpen because that is what it does now (it never closes it)
  • adjust the last test scenario that changes " sharing permissions and expiration date for both a user and a group" so that it does all the actions first, then checks the settings visible in the webUI and the settings of the shares via the API

@phil-davis phil-davis merged commit d5264d0 into master Feb 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the share-permissions branch February 18, 2020 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants