-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-only] acceptance tests for sharing with multiple users and groups #36915
Conversation
1376465
to
ec07fde
Compare
Codecov Report
@@ Coverage Diff @@
## master #36915 +/- ##
============================================
+ Coverage 64.49% 64.68% +0.19%
Complexity 19138 19138
============================================
Files 1270 1270
Lines 74912 74912
Branches 1329 1329
============================================
+ Hits 48313 48460 +147
+ Misses 26208 26061 -147
Partials 391 391
Continue to review full report at Codecov.
|
1da08ea
to
b7d3287
Compare
1cdfa99
to
933f4cb
Compare
61a4928
to
f2aadb5
Compare
2689e0f
to
acc3190
Compare
acc3190
to
39a0285
Compare
39a0285
to
73ab0dd
Compare
73ab0dd
to
03d4ffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
03d4ffb
to
32f584f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added commits to:
- do a general rename of
$fd
in all places to$bodyRows
(I don't know what$fd
was supposed to stand for somewhere in past history) - rename
toggleShareActions
toopenShareActionsIfNotOpen
because that is what it does now (it never closes it) - adjust the last test scenario that changes " sharing permissions and expiration date for both a user and a group" so that it does all the actions first, then checks the settings visible in the webUI and the settings of the shares via the API
Description
Adds acceptance test for sharing with users and groups having the same name and changing permissions and expiration date
Related Issue
#36818
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: