-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dav.enable.tech_preview #36815
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36815 +/- ##
============================================
+ Coverage 64.68% 64.69% +<.01%
+ Complexity 19122 19117 -5
============================================
Files 1269 1269
Lines 74779 74774 -5
Branches 1320 1320
============================================
+ Hits 48373 48376 +3
+ Misses 26018 26010 -8
Partials 388 388
Continue to review full report at Codecov.
|
c3979a9
to
c3443df
Compare
$ocVersion = SetupHelper::getSystemConfigValue('version'); | ||
// dav.enable.tech_preview was used in some ownCloud versions before 10.4.0 | ||
// only set it on those versions of ownCloud | ||
if (\version_compare($ocVersion, '10.4.0') === -1) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: I checked this locally to make sure we do not go down this path on the current core 10.4.0.1 version, and will go down this path on 10.3.*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests look good to me
@micbar the backend code changes are very simple. Artur has reviewed the test code changes. |
Description
Make the new trashbin API and new public links API available by default.
Related doc PR owncloud/docs#2248
Related Issue
How Has This Been Tested?
CI
Types of changes
Checklist: