-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For 10.4] On the public preview route the share password needs to be verified a… #36571
Conversation
e3ab726
to
cd0d8c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See Comments. Rest LGTM
@phil-davis This would be a good candidate for an acceptance test. |
@haribhandari07 please assign someone to make acceptance tests. |
…gain to not grant unauthorized access
cd0d8c2
to
1cd3125
Compare
Codecov Report
@@ Coverage Diff @@
## master #36571 +/- ##
============================================
- Coverage 64.66% 64.65% -0.01%
Complexity 19049 19049
============================================
Files 1269 1269
Lines 74498 74503 +5
Branches 1311 1311
============================================
Hits 48171 48171
- Misses 25941 25946 +5
Partials 386 386
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good
Tested on Damken-Cloud, The patch works! |
…gain to not grant unauthorized access
Description
The public preview route did not check the share link password
How Has This Been Tested?
Types of changes
Checklist: