Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipOnOcV10.3 the trashbin scenarios fixed in 10.4 #36543

Merged
merged 1 commit into from
Dec 9, 2019

Conversation

phil-davis
Copy link
Contributor

Description

PR #36488 fixed some trashbin access issues and adjusted the acceptance test scenarios. That will be released in core 10.4. The adjusted scenarios are not expected to pass when run against core 10.3, so skip them in that case.

This will stop "false" fails being reported in e.g. encryption app nightly tests that also run against core latest (currently 10.3). e.g. https://drone.owncloud.com/owncloud/encryption/1025/63/14

Related Issue

#36378

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Dec 9, 2019

Codecov Report

Merging #36543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36543   +/-   ##
=========================================
  Coverage     64.66%   64.66%           
  Complexity    19049    19049           
=========================================
  Files          1269     1269           
  Lines         74497    74497           
  Branches       1311     1311           
=========================================
  Hits          48170    48170           
  Misses        25941    25941           
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54.02% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (-0.43%) 19049 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/MySQLMigrator.php 100% <0%> (ø) 5% <0%> (ø) ⬇️
lib/private/Repair/Collation.php 87.5% <0%> (ø) 12% <0%> (ø) ⬇️
lib/private/DB/AdapterOCI8.php 86.66% <0%> (ø) 4% <0%> (ø) ⬇️
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 85.18% <0%> (ø) 18% <0%> (ø) ⬇️
lib/private/Repair/InnoDB.php 78.94% <0%> (ø) 6% <0%> (ø) ⬇️
lib/private/DB/OracleMigrator.php 76.84% <0%> (ø) 10% <0%> (ø) ⬇️
lib/private/DB/OracleConnection.php 66.66% <0%> (ø) 12% <0%> (ø) ⬇️
...ilder/ExpressionBuilder/MySqlExpressionBuilder.php 62.5% <0%> (ø) 3% <0%> (ø) ⬇️
lib/private/DB/AdapterMySQL.php 50% <0%> (ø) 4% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 90.41% <0%> (ø) 22% <0%> (ø) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2c33f...8a41efd. Read the comment docs.

@phil-davis phil-davis merged commit 2b91bc6 into master Dec 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the skipOnOcV10.3-some-trashbin-scenarios branch December 9, 2019 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants