Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[For 10.4] Set 599 HTTP code on error #36413

Merged
merged 5 commits into from
Dec 4, 2019
Merged

[For 10.4] Set 599 HTTP code on error #36413

merged 5 commits into from
Dec 4, 2019

Commits on Nov 28, 2019

  1. Set 500 HTTP code on error

    @jvillafanez
    jvillafanez committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    6910328 View commit details
    Browse the repository at this point in the history

  2. Rewrite favicon.ico to the right location 

    This could happen if the server crashes using the web UI. The browser
sends a request to the /favicon.ico URL instead of
/core/img/favicon.ico, which is configured in the ownCloud's web pages.
Without this fix, the server responds with a 500 instead of a 200 or 404
    @jvillafanez
    jvillafanez committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9111ba0 View commit details
    Browse the repository at this point in the history

  3. Remove onShutdown error handler 

    It was causing an additional DBALException when there is no DB
connection. The logger was trying to access to the DB during the
shutdown process, causing an unhandled exception to appear in apache
    @jvillafanez
    jvillafanez committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    faddb89 View commit details
    Browse the repository at this point in the history

  4. Use a different logger and log file if ownCloud is broken 

    The endpoints will return a 599 HTTP status to distinguish app failures,
which shouldn't break ownCloud and can still be reported through normal
means.
It will use a different file to log what happened without messing with
the owncloud.log file and without bothering the web server's log

Include new configuration option in config.sample.php file
    @jvillafanez
    jvillafanez committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    9e1b300 View commit details
    Browse the repository at this point in the history

  5. Add changelog item

    @jvillafanez
    jvillafanez committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    3674fa0 View commit details
    Browse the repository at this point in the history