Fix #36114: Update documentation about uploadwriteonly permission #36215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
uploadwriteonly
is something we created for only providingread
andcreate
but noupdate
permissions. So,read(1) + create(4) = uploadwriteonly(5)
.The following scenario makes it clearer.
Notice the
403
when trying to update.Also,
SharingHelper::getPermissionSum()
does not support derived permissions. So, the annotations/comments onSharingHelper::createShare()
(which passes permissions togetPermissionSum()
) is lying. This fixes it. Anything derived should be parsed first usingSharing::splitPermissionsString([array])
.#35825 changed
Sharing::getPermissionSum()
to not handle derived permissions.Related Issue
Motivation and Context
Types of changes
Checklist:
Open tasks: