Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-10.3.0] Make sure to parse only if attributes are json string in reshare #36214

Merged
merged 1 commit into from
Sep 24, 2019
Merged

[release-10.3.0] Make sure to parse only if attributes are json string in reshare #36214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/js/shareitemmodel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -790,8 +790,9 @@
}
}
for (i = 0; i < SHARE_RESPONSE_JSON_PROPS.length; i++) {
// Parse JSON if not yet parsed
var propJson = SHARE_RESPONSE_JSON_PROPS[i];
if (!_.isUndefined(share[propJson])) {
if (!_.isUndefined(share[propJson]) && !_.isObject(share[propJson])) {
share[propJson] = JSON.parse(share[propJson]);
}
}
Expand Down