-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle no longer existing resource of a link share #36066
Conversation
Codecov Report
@@ Coverage Diff @@
## master #36066 +/- ##
=======================================
Coverage 53.85% 53.85%
=======================================
Files 63 63
Lines 7377 7377
Branches 1301 1301
=======================================
Hits 3973 3973
Misses 3019 3019
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #36066 +/- ##
=======================================
Coverage 54% 54%
=======================================
Files 63 63
Lines 7403 7403
Branches 1307 1307
=======================================
Hits 3998 3998
Misses 3019 3019
Partials 386 386
Continue to review full report at Codecov.
|
@DeepDiver1975 this does not fix #36005, linked the wrong issue? |
@individual-it seems he updated the top post, please check again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 code looks fine
waiting for @individual-it to confirm and merge |
a8f72f0
to
a735004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a test, rebased the branch and fixed the commit message
Description
Handle NotFound exception properly
Related Issue
How Has This Been Tested?
Types of changes
Checklist:
Open tasks: