Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating symfony/polyfill-* (v1.11.0 => v1.12.0) #35989

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Updating symfony/polyfill-* (v1.11.0 => v1.12.0) #35989

merged 1 commit into from
Aug 7, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 7, 2019 •
edited
Loading

Description

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 7 updates, 0 removals
  - Updating symfony/polyfill-iconv (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-php72 (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-mbstring (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-intl-idn (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-util (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-php56 (v1.11.0 => v1.12.0): Loading from cache
  - Updating symfony/polyfill-ctype (v1.11.0 => v1.12.0): Loading from cache

The only real addition/change is in symfony/polyfill-mbstring
symfony/polyfill-mbstring@v1.11.0...v1.12.0
It adds mb_str_split function.

Motivation and Context

Update groups of symfony dependencies together.
Be up-to-date with dependencies before making any release candidate.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Aug 7, 2019
individual-it
individual-it requested changes Aug 7, 2019
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random file added?

@phil-davis phil-davis force-pushed the bump-symfony-polyfill-v1.12.0 branch from 563af5c to 1596c73 Compare August 7, 2019 04:23
@phil-davis
Copy link
Contributor Author

@individual-it I created a negative random file to balance it out ;)

@phil-davis
Copy link
Contributor Author

There were various yarn etc errors in drone. I restarted the build.

@phil-davis phil-davis merged commit 805c27d into master Aug 7, 2019
@delete-merged-branch delete-merged-branch bot deleted the bump-symfony-polyfill-v1.12.0 branch August 7, 2019 06:59
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

9 similar comments
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019 •
edited
Loading

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #35989 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35989   +/-   ##
=========================================
  Coverage     65.44%   65.44%           
  Complexity    20174    20174           
=========================================
  Files          1296     1296           
  Lines         76362    76362           
  Branches       1301     1301           
=========================================
  Hits          49975    49975           
  Misses        26002    26002           
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.68% <ø> (ø) 20174 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fb17eb...1596c73. Read the comment docs.

@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@individual-it individual-it individual-it approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@phil-davis phil-davis

Labels
4 - To release dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @individual-it @patrickjahns