Keep DAV properties when file goes to trashbin

[VicDeo]

Description

Do not delete dav properties when the file is found in the trashbin

Related Issue

Motivation and Context

Props are cleaned, files are kept

How Has This Been Tested?

0. Enable trashbin
1. Upload a file
2. Add a custom property into oc_properties table for it's fileId
3. Put the file into trashbin and restore

Expected

Property is kept

Actual

Property is deleted

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

TODO

• deletion from trashbin doesn't go through dav, so when the file is finally deleted it's properties remain

[codecov]

Codecov Report

Merging #35954 into master will increase coverage by <.01%.
The diff coverage is 63.63%.

@@             Coverage Diff              @@
##             master   #35954      +/-   ##
============================================
+ Coverage      65.4%    65.4%   +<.01%     
- Complexity    20197    20199       +2     
============================================
  Files          1299     1299              
  Lines         76762    76770       +8     
  Branches       1301     1301              
============================================
+ Hits          50203    50209       +6     
- Misses        26174    26176       +2     
  Partials        385      385

Flag	Coverage Δ	Complexity Δ
#javascript	53.85% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	66.62% <63.63%> (ø)	20199 <0> (+2)	⬆️

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/Server.php	52.7% <0%> (-0.73%)	24 <0> (ø)
apps/dav/lib/Connector/Sabre/ServerFactory.php	95.94% <100%> (+0.05%)	10 <0> (ø)	⬇️
...ps/dav/lib/DAV/AbstractCustomPropertiesBackend.php	98.24% <100%> (+0.03%)	19 <0> (ø)	⬇️
apps/dav/lib/DAV/FileCustomPropertiesBackend.php	89.32% <100%> (+0.43%)	33 <0> (+2)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e2d11f...cefaf10. Read the comment docs.

[VicDeo]

mhm. daily-stable10-qa.tar.bz2?
https://drone.owncloud.com/owncloud/core/19882/400
https://drone.owncloud.com/owncloud/core/19882/404
https://drone.owncloud.com/owncloud/core/19882/852
https://drone.owncloud.com/owncloud/core/19882/910

[VicDeo]

@phil-davis any idea why the current master tip still uses daily-stable10-qa.tar.bz2 for the federated server?

[phil-davis]

@phil-davis any idea why the current master tip still uses daily-stable10-qa.tar.bz2 for the federated server?

Thanks for pointing this out. My idea is that it was missed - I raised PR #35964 to fixup various leftover stable10 references.

[micbar]

👍