Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the new iOS app #35918

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Added the new iOS app #35918

merged 1 commit into from
Jul 30, 2019

Conversation

ChrisEdS
Copy link
Contributor

Description

We have a new iOS app in the AppStore. In the next release all users should know about it.

Motivation and Context

Promote the all-new iOS app.

How Has This Been Tested?

Manual tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #35918 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #35918   +/-   ##
=========================================
  Coverage      65.8%    65.8%           
  Complexity    18760    18760           
=========================================
  Files          1229     1229           
  Lines         70856    70856           
  Branches       1289     1289           
=========================================
  Hits          46626    46626           
  Misses        23852    23852           
  Partials        378      378
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 67.18% <100%> (ø) 18760 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/defaults.php 59.25% <100%> (ø) 45 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e208e43...df95f24. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #35918 into master will increase coverage by 0.7%.
The diff coverage is 79.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #35918     +/-   ##
===========================================
+ Coverage      65.1%    65.8%   +0.7%     
+ Complexity    20197    18760   -1437     
===========================================
  Files          1302     1229     -73     
  Lines         77158    70856   -6302     
  Branches       1301     1289     -12     
===========================================
- Hits          50232    46626   -3606     
+ Misses        26541    23852   -2689     
+ Partials        385      378      -7
Flag Coverage Δ Complexity Δ
#javascript 53.7% <ø> (-0.16%) 0 <ø> (ø)
#phpunit 67.18% <79.55%> (+0.89%) 18760 <966> (-1437) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Upload/AssemblyStreamZsync.php 88.37% <ø> (ø) 33 <0> (?)
...s/dav/appinfo/Migrations/Version20170427182800.php 0% <ø> (ø) 2 <0> (ø) ⬇️
apps/dav/lib/TrashBin/TrashBinHome.php 100% <ø> (ø) 7 <0> (ø) ⬇️
apps/dav/lib/Upload/ChunkLocationProvider.php 100% <ø> (ø) 4 <0> (ø) ⬇️
apps/dav/lib/Upload/FutureFile.php 88.57% <ø> (ø) 16 <0> (ø) ⬇️
apps/dav/lib/CardDAV/SyncJob.php 0% <ø> (ø) 2 <0> (ø) ⬇️
apps/dav/lib/Upload/FutureFileZsync.php 83.33% <ø> (ø) 11 <0> (?)
apps/dav/lib/TrashBin/TrashBinPlugin.php 94.44% <ø> (ø) 7 <0> (ø) ⬇️
apps/dav/lib/CalDAV/Schedule/Plugin.php 0% <ø> (ø) 2 <0> (ø) ⬇️
...nnector/Sabre/Exception/PasswordLoginForbidden.php 0% <ø> (ø) 2 <0> (ø) ⬇️
... and 448 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd3df85...9950900. Read the comment docs.

@DeepDiver1975 DeepDiver1975 changed the base branch from master to archive/master July 30, 2019 08:27
Use English URL instead of German
@DeepDiver1975 DeepDiver1975 changed the base branch from archive/master to master July 30, 2019 08:29
@DeepDiver1975 DeepDiver1975 merged commit 4b82d50 into master Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-new-ios-app branch July 30, 2019 08:30
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants