Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Allow selecting installation errors #35681

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Jun 26, 2019

Backport of #35680

Description

Partially reverts 1622589

Motivation and Context

Prevent user distraction

How Has This Been Tested?

  1. try installing OC from Web UI with wrong DB credentials
  2. try copying the error message

Expected

possible

Actual

impossible

Screenshots (if appropriate):

not selectable

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@VicDeo VicDeo added this to the development milestone Jun 26, 2019
@VicDeo VicDeo self-assigned this Jun 26, 2019
@VicDeo VicDeo mentioned this pull request Jun 26, 2019
11 tasks
@VicDeo VicDeo merged commit dff3bf9 into stable10 Jun 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-fix-unselectable-error-message branch June 27, 2019 12:31
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants