Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.2.1] set default expiration date if expiration date is enforced and it is new share #35593

Merged
merged 1 commit into from
Jun 19, 2019
Merged

[10.2.1] set default expiration date if expiration date is enforced and it is new share #35593

merged 1 commit into from
Jun 19, 2019

Conversation

patrickjahns
Copy link
Contributor

@patrickjahns patrickjahns commented Jun 19, 2019 •
edited by phil-davis
Loading

Description

Backport of #35564

Related Issue

Motivation and Context

Fix this in 10.2.1

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

⛔️

@patrickjahns patrickjahns added this to the QA milestone Jun 19, 2019
@patrickjahns patrickjahns self-assigned this Jun 19, 2019
@phil-davis phil-davis mentioned this pull request Jun 19, 2019
Merged
11 tasks
@micbar micbar merged commit 1d1d126 into release-10.2.1 Jun 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.1-set-default-expiry branch June 19, 2019 11:30
@davitol davitol mentioned this pull request Jun 25, 2019
Closed
11 tasks
@patrickjahns patrickjahns modified the milestone: QA Jun 27, 2019
@phil-davis phil-davis mentioned this pull request Aug 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karakayasemi karakayasemi karakayasemi approved these changes

@micbar micbar micbar approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@patrickjahns patrickjahns

Labels
4 - To release
Projects
None yet
Milestone
10.2.1
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickjahns @micbar @karakayasemi @phil-davis