Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-10.2.0] encode jobs that have an array as job value #35228

Merged
merged 1 commit into from
May 15, 2019

Conversation

phil-davis
Copy link
Contributor

Signed-off-by: Patrick Jahns [email protected]

Backport #35224 to 10.2 release branch.

@phil-davis phil-davis requested a review from PVince81 May 15, 2019 02:36
@phil-davis phil-davis self-assigned this May 15, 2019
@phil-davis phil-davis changed the title encode jobs that have an array as job value [release-10.2.0] encode jobs that have an array as job value May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #35228 into release-10.2.0 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35228      +/-   ##
====================================================
+ Coverage             64.39%   64.42%   +0.03%     
- Complexity            20049    20081      +32     
====================================================
  Files                  1285     1285              
  Lines                 76842    77018     +176     
  Branches               1308     1308              
====================================================
+ Hits                  49480    49618     +138     
- Misses                26978    27016      +38     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.56% <100%> (+0.03%) 20081 <2> (+32) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/Command/Background/Queue/Status.php 100% <100%> (ø) 6 <2> (+2) ⬆️
apps/federatedfilesharing/lib/FedShareManager.php 77.72% <0%> (-2.66%) 35% <0%> (+10%)
...es_sharing/lib/Controller/Share20OcsController.php 86.49% <0%> (-1.07%) 222% <0%> (+20%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24e0e79...472797b. Read the comment docs.

@patrickjahns patrickjahns added this to the QA milestone May 15, 2019
@patrickjahns
Copy link
Contributor

Added to QA-milestone to have it in the release milestone

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit eb18d9c into release-10.2.0 May 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.0-fix-35222-job-status branch May 15, 2019 12:44
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants