Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Configurable thumbnail path #35196

Merged
merged 2 commits into from
May 10, 2019
Merged

Conversation

PVince81
Copy link
Contributor

Forward port of #35131 to master

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for adding that 👍

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/17263/869

git fetch --no-tags --depth=50 origin +refs/pull/35196/merge:
fatal: expected shallow/unshallow, got ERR upload-pack: not our ref e76734932290d039a1f4f473fef1874d26c87e8a
fatal: the remote end hung up unexpectedly
time="2019-05-10T07:07:06Z" level=fatal msg="exit status 128"

some annoying github timing thing
I will restart drone

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #35196 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35196      +/-   ##
============================================
+ Coverage      65.5%    65.5%   +<.01%     
- Complexity    18640    18644       +4     
============================================
  Files          1217     1218       +1     
  Lines         70554    70565      +11     
  Branches       1296     1296              
============================================
+ Hits          46213    46224      +11     
  Misses        23964    23964              
  Partials        377      377
Flag Coverage Δ Complexity Δ
#javascript 53.5% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.89% <100%> (ø) 18644 <4> (+4) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Mount/PreviewsMountProvider.php 100% <100%> (ø) 4 <4> (?)
lib/private/Server.php 86.57% <100%> (+0.01%) 253 <0> (ø) ⬇️
lib/private/Files/Mount/CacheMountProvider.php 100% <100%> (ø) 4 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 318470d...30772cd. Read the comment docs.

@PVince81 PVince81 merged commit 100a08c into master May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the configurable-thumbnail-path branch May 10, 2019 08:40
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants