Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump icewind/streams from 0.5.2 to 0.7.1 #34614

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Feb 25, 2019

Bumps icewind/streams from 0.5.2 to 0.7.1.

Release notes

Sourced from icewind/streams's releases.

0.7.1

  • Fix regression with read callback in callback wrapper

0.7.0

  • Fix incorrect number of read bytes being reported when the wrapped stream doesn't return the full number of requested bytes
  • Add pre-close callback to the callback wrapper

0.6.1

  • Use more reliable way to detect stream type

0.6.0

  • Add CountWrapper to count the number of bytes read and written to a stream
Commits
  • 4db3ed6 Merge pull request #10 from rullzer/master
  • 8c45c9a Pass the strlen to the readCallback as was expected
  • e1b5ac1 Merge pull request #9 from rullzer/enh/add_preClose_callback
  • 3a28b61 Add test
  • 3c98a75 Add a preClose callback
  • 74d0347 Merge pull request #8 from rullzer/fix/read_bytes_is_not_requested_bytes
  • 0bc7fe4 Fix read in callbackwrapper
  • 0a78597 use better method to determine when a stream is a directory stream
  • 851b822 add php 7.1 and 7.2 tests, remove hhvm
  • 03ad018 Add CountWrapper
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot added dependencies php Pull requests that update Php code labels Feb 25, 2019
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34614   +/-   ##
=========================================
  Coverage     65.23%   65.23%           
  Complexity    18438    18438           
=========================================
  Files          1203     1203           
  Lines         69819    69819           
  Branches       1280     1280           
=========================================
  Hits          45548    45548           
  Misses        23899    23899           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.64% <ø> (ø) 18438 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a922eaf...df23dce. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #34614   +/-   ##
=========================================
  Coverage     65.35%   65.35%           
  Complexity    18484    18484           
=========================================
  Files          1208     1208           
  Lines         69969    69969           
  Branches       1280     1280           
=========================================
  Hits          45728    45728           
  Misses        23869    23869           
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.04% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.76% <ø> (ø) 18484 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c2a19...d5d67c4. Read the comment docs.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/icewind/streams-0.7.1 branch from df23dce to f085cd1 Compare March 4, 2019 11:40
@mmattel
Copy link
Contributor

mmattel commented Mar 4, 2019

Q: @PVince81 What is necessary to get streams updated to 0.7.1 in master/stable10

@PVince81
Copy link
Contributor

PVince81 commented Mar 4, 2019

@mmattel checking the changelog and evaluating whether there could be parts of our storage code could be affected by the changes

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/icewind/streams-0.7.1 branch from f085cd1 to a37a489 Compare March 18, 2019 15:44
@phil-davis phil-davis self-assigned this Mar 20, 2019
@phil-davis
Copy link
Contributor

@dependabot recreate

@phil-davis
Copy link
Contributor

This matches with #34617 for stable10
And with #34537 #34538 for files_external
So I guess all 4 PRs should be merged together once it is decided that it is OK.
That will help with getting stable10 and master up-to-date and consistent.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/icewind/streams-0.7.1 branch 3 times, most recently from 73e5786 to bfcef51 Compare March 24, 2019 02:47
@dependabot-preview dependabot-preview bot force-pushed the dependabot/composer/icewind/streams-0.7.1 branch from bfcef51 to d5d67c4 Compare March 24, 2019 02:56
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get master up-to-date then someone can look at the stable10 bot PR #34617

@phil-davis phil-davis merged commit b6c3625 into master Mar 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/composer/icewind/streams-0.7.1 branch March 24, 2019 04:08
@lock lock bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - To release dependencies php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants