Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled docs from community edition #34611

Merged
merged 1 commit into from
Feb 25, 2019
Merged

Conversation

sharidas
Copy link
Contributor

Remove bundled docs from community edition.

Signed-off-by: Sujith H [email protected]

Description

Remove bundled docs link from the community edition. The changes made in this PR to achieve this include:

  • Grepped through the code base and removed Help in the legacy/app.php.
  • Also removed settings_help from the routes.php

Related Issue

Motivation and Context

Remove docs link from the community edition. Removed the Help from the settings.

How Has This Been Tested?

  • Disabled enterprise_key
  • Clicked Settings link and this is what we could see
    admin_settings
  • Navigate to settings/help ( manually type in the addressbar after the http://localhost/, or wherever your oC instance is pointing to ), user will not see help page.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Remove bundled docs from community edition.

Signed-off-by: Sujith H <[email protected]>
@sharidas sharidas added this to the development milestone Feb 25, 2019
@sharidas sharidas self-assigned this Feb 25, 2019
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34611 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34611      +/-   ##
============================================
+ Coverage     65.23%   65.23%   +<.01%     
+ Complexity    18440    18438       -2     
============================================
  Files          1203     1203              
  Lines         69825    69816       -9     
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
+ Misses        23904    23897       -7     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.64% <ø> (ø) 18438 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 64.89% <ø> (+1.08%) 161 <0> (-2) ⬇️
settings/routes.php 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aaf87...48c2278. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34611 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34611      +/-   ##
============================================
+ Coverage     65.23%   65.23%   +<.01%     
+ Complexity    18440    18438       -2     
============================================
  Files          1203     1203              
  Lines         69825    69816       -9     
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
+ Misses        23904    23897       -7     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.64% <ø> (ø) 18438 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 64.89% <ø> (+1.08%) 161 <0> (-2) ⬇️
settings/routes.php 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aaf87...48c2278. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34611 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34611      +/-   ##
============================================
+ Coverage     65.23%   65.23%   +<.01%     
+ Complexity    18440    18438       -2     
============================================
  Files          1203     1203              
  Lines         69825    69816       -9     
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
+ Misses        23904    23897       -7     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.64% <ø> (ø) 18438 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 64.89% <ø> (+1.08%) 161 <0> (-2) ⬇️
settings/routes.php 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aaf87...48c2278. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #34611 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #34611      +/-   ##
============================================
+ Coverage     65.23%   65.23%   +<.01%     
+ Complexity    18440    18438       -2     
============================================
  Files          1203     1203              
  Lines         69825    69816       -9     
  Branches       1280     1280              
============================================
- Hits          45549    45547       -2     
+ Misses        23904    23897       -7     
  Partials        372      372
Flag Coverage Δ Complexity Δ
#javascript 53.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.64% <ø> (ø) 18438 <ø> (-2) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/app.php 64.89% <ø> (+1.08%) 161 <0> (-2) ⬇️
settings/routes.php 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80aaf87...48c2278. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@PVince81 PVince81 merged commit bb71b2d into master Feb 25, 2019
@PVince81 PVince81 deleted the remove-bundled-docs branch February 25, 2019 15:45
@PVince81
Copy link
Contributor

@sharidas please backport

@sharidas
Copy link
Contributor Author

Backport PR: #34612

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundled docs missing in release
2 participants