-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove bundled docs from community edition #34611
Conversation
Remove bundled docs from community edition. Signed-off-by: Sujith H <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #34611 +/- ##
============================================
+ Coverage 65.23% 65.23% +<.01%
+ Complexity 18440 18438 -2
============================================
Files 1203 1203
Lines 69825 69816 -9
Branches 1280 1280
============================================
- Hits 45549 45547 -2
+ Misses 23904 23897 -7
Partials 372 372
Continue to review full report at Codecov.
|
3 similar comments
Codecov Report
@@ Coverage Diff @@
## master #34611 +/- ##
============================================
+ Coverage 65.23% 65.23% +<.01%
+ Complexity 18440 18438 -2
============================================
Files 1203 1203
Lines 69825 69816 -9
Branches 1280 1280
============================================
- Hits 45549 45547 -2
+ Misses 23904 23897 -7
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34611 +/- ##
============================================
+ Coverage 65.23% 65.23% +<.01%
+ Complexity 18440 18438 -2
============================================
Files 1203 1203
Lines 69825 69816 -9
Branches 1280 1280
============================================
- Hits 45549 45547 -2
+ Misses 23904 23897 -7
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #34611 +/- ##
============================================
+ Coverage 65.23% 65.23% +<.01%
+ Complexity 18440 18438 -2
============================================
Files 1203 1203
Lines 69825 69816 -9
Branches 1280 1280
============================================
- Hits 45549 45547 -2
+ Misses 23904 23897 -7
Partials 372 372
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
@sharidas please backport |
Backport PR: #34612 |
Remove bundled docs from community edition.
Signed-off-by: Sujith H [email protected]
Description
Remove bundled docs link from the community edition. The changes made in this PR to achieve this include:
Help
in the legacy/app.php.settings_help
from the routes.phpRelated Issue
Motivation and Context
Remove docs link from the community edition. Removed the
Help
from the settings.How Has This Been Tested?
Settings
link and this is what we could seesettings/help
( manually type in the addressbar after the http://localhost/, or wherever your oC instance is pointing to ), user will not see help page.Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: