Fix systemtatgs get,create and update API #34604

sharidas · 2019-02-25T11:22:27Z

Fix systemtags get, create and update API.
Due to recent changes made to add static tags,
the API changes are not compatible with the
older version. Hence to make them work as
before, minor changes are made.

Signed-off-by: Sujith H [email protected]

Description

Because of recent changes made to add static tags, there were changes made to getTag, createTag and updateTag. As a result they were not compatible with the older versions of oC. For example: when any of these methods were called by the user without last argument userEditable, the results were not as expected. The user gets result which were incorrect. Hence this change would help to rectify this problem. The API's should not break.

Related Issue

Fixes The SystemTagManager API should behave as it was before for methods like createTag, getTag #34594

Motivation and Context

Fix the API breakage that happened in the systemtags for getTag, createTag and updateTag methods.

How Has This Been Tested?

Tested with unit test.
Tested by adding small snippet code to create tag, get tag and update it and verify. Sample code :

\OC::$server->getSystemTagManager()->createTag('invisibleTag', false, false);
$tag = \OC::$server->getSystemTagManager()->getTag('invisibleTag', false, false);
\OC::$server->getSystemTagManager()->updateTag($tag->getId(), 'visibleTag', true, true);

And the output captured for the values in $tag:

name = invisibleTag
UserVisible = 0
UserAssignable = 0
UserEditable 0

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

Backport (if applicable set "backport-request" label and remove when the backport was done)

Fix systemtags get, create and update API. Due to recent changes made to add static tags, the API changes are not compatible with the older version. Hence to make them work as before, minor changes are made. Signed-off-by: Sujith H <[email protected]>

codecov · 2019-02-25T11:54:26Z

Codecov Report

Merging #34604 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34604      +/-   ##
============================================
+ Coverage     65.22%   65.23%   +<.01%     
- Complexity    18434    18440       +6     
============================================
  Files          1203     1203              
  Lines         69816    69825       +9     
  Branches       1280     1280              
============================================
+ Hits          45540    45549       +9     
  Misses        23904    23904              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	`53.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.63% <100%> (ø)`	`18440 <15> (+6)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/SystemTag/SystemTagManager.php	`96.25% <100%> (+0.14%)`	`55 <15> (+6)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517b62...ef32686. Read the comment docs.

codecov · 2019-02-25T11:54:56Z

Codecov Report

Merging #34604 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34604      +/-   ##
============================================
+ Coverage     65.22%   65.23%   +<.01%     
- Complexity    18434    18440       +6     
============================================
  Files          1203     1203              
  Lines         69816    69825       +9     
  Branches       1280     1280              
============================================
+ Hits          45540    45549       +9     
  Misses        23904    23904              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	`53.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.63% <100%> (ø)`	`18440 <15> (+6)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/SystemTag/SystemTagManager.php	`96.25% <100%> (+0.14%)`	`55 <15> (+6)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517b62...ef32686. Read the comment docs.

codecov · 2019-02-25T11:55:01Z

Codecov Report

Merging #34604 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34604      +/-   ##
============================================
+ Coverage     65.22%   65.23%   +<.01%     
- Complexity    18434    18440       +6     
============================================
  Files          1203     1203              
  Lines         69816    69825       +9     
  Branches       1280     1280              
============================================
+ Hits          45540    45549       +9     
  Misses        23904    23904              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	`53.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.63% <100%> (ø)`	`18440 <15> (+6)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/SystemTag/SystemTagManager.php	`96.25% <100%> (+0.14%)`	`55 <15> (+6)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517b62...ef32686. Read the comment docs.

codecov · 2019-02-25T11:55:10Z

Codecov Report

Merging #34604 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #34604      +/-   ##
============================================
+ Coverage     65.22%   65.23%   +<.01%     
- Complexity    18434    18440       +6     
============================================
  Files          1203     1203              
  Lines         69816    69825       +9     
  Branches       1280     1280              
============================================
+ Hits          45540    45549       +9     
  Misses        23904    23904              
  Partials        372      372

Flag	Coverage Δ	Complexity Δ
#javascript	`53.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`66.63% <100%> (ø)`	`18440 <15> (+6)`	⬆️

Impacted Files	Coverage Δ	Complexity Δ
lib/private/SystemTag/SystemTagManager.php	`96.25% <100%> (+0.14%)`	`55 <15> (+6)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1517b62...ef32686. Read the comment docs.

PVince81

👍 fine for now

PVince81 · 2019-02-25T13:36:47Z

lib/private/SystemTag/SystemTagManager.php

+		if ($userEditable === null) {
+			$userEditable = 1;
+		} elseif (\is_bool($userEditable)) {
+			$userEditable = (int)$userEditable;


it's a bit weird to check whether it's a boolean and then convert it to an int.

I also still wonder why we used ints below instead of boolean

PVince81 · 2019-02-25T13:37:26Z

@sharidas please backport

sharidas · 2019-02-25T14:13:05Z

Backport PR: #34610

sharidas added the 2 - Developing label Feb 25, 2019

sharidas added this to the development milestone Feb 25, 2019

sharidas self-assigned this Feb 25, 2019

sharidas changed the title ~~[WIP] Fix systemtatgs get,create and update API~~ Fix systemtatgs get,create and update API Feb 25, 2019

sharidas requested a review from PVince81 February 25, 2019 12:03

sharidas mentioned this pull request Feb 25, 2019

The SystemTagManager API should behave as it was before for methods like createTag, getTag #34594

Closed

sharidas added 3 - To Review and removed 2 - Developing labels Feb 25, 2019

PVince81 approved these changes Feb 25, 2019

View reviewed changes

PVince81 merged commit 80aaf87 into master Feb 25, 2019

PVince81 deleted the systemtag-api-fix branch February 25, 2019 13:37

PVince81 added the backport-request label Feb 25, 2019

sharidas mentioned this pull request Feb 25, 2019

[stable10] Backport of Fix systemtatgs get,create and update API #34610

Merged

11 tasks

sharidas removed the backport-request label Feb 25, 2019

lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix systemtatgs get,create and update API #34604

Fix systemtatgs get,create and update API #34604

sharidas commented Feb 25, 2019 •

edited

Loading

codecov bot commented Feb 25, 2019

codecov bot commented Feb 25, 2019

codecov bot commented Feb 25, 2019 •

edited

Loading

codecov bot commented Feb 25, 2019 •

edited

Loading

PVince81 left a comment

PVince81 Feb 25, 2019

PVince81 commented Feb 25, 2019

sharidas commented Feb 25, 2019

Fix systemtatgs get,create and update API #34604

Fix systemtatgs get,create and update API #34604

Conversation

sharidas commented Feb 25, 2019 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

codecov bot commented Feb 25, 2019

Codecov Report

codecov bot commented Feb 25, 2019

Codecov Report

codecov bot commented Feb 25, 2019 • edited Loading

Codecov Report

codecov bot commented Feb 25, 2019 • edited Loading

Codecov Report

PVince81 left a comment

Choose a reason for hiding this comment

PVince81 Feb 25, 2019

Choose a reason for hiding this comment

PVince81 commented Feb 25, 2019

sharidas commented Feb 25, 2019

sharidas commented Feb 25, 2019 •

edited

Loading

codecov bot commented Feb 25, 2019 •

edited

Loading

codecov bot commented Feb 25, 2019 •

edited

Loading