Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Repair step list and execution from occ #34499

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Conversation

karakayasemi
Copy link
Contributor

Backport of #29830

occ maintenance:repair --list and occ maintenance:repair --single "OC\Repair\MoveAvatarOutsideHome" commands are added.

  • the repair steps of applications added to list option (the dav app has repair steps).
  • only --list option run if the server is not in maintenance mode.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34499 into stable10 will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           stable10   #34499      +/-   ##
============================================
+ Coverage     45.17%    45.2%   +0.02%     
============================================
  Files           116      116              
  Lines         11495    11482      -13     
  Branches       1292     1291       -1     
============================================
- Hits           5193     5190       -3     
+ Misses         5922     5912      -10     
  Partials        380      380
Flag Coverage Δ
#javascript 53.32% <ø> (+0.05%) ⬆️
#phpunit 31.02% <ø> (ø) ⬆️
Impacted Files Coverage Δ
settings/js/setpassword.js 82.85% <0%> (+16.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcdad1...3c5565e. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #34499 into stable10 will increase coverage by 0.24%.
The diff coverage is 90.36%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34499      +/-   ##
==============================================
+ Coverage       63.59%   63.84%   +0.24%     
- Complexity      19091    19101      +10     
==============================================
  Files            1264     1264              
  Lines           75317    75355      +38     
  Branches         1292     1292              
==============================================
+ Hits            47901    48110     +209     
+ Misses          27036    26865     -171     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.27% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.98% <90.36%> (+0.27%) 19101 <9> (+10) ⬆️
Impacted Files Coverage Δ Complexity Δ
core/register_command.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Repair/MoveAvatarOutsideHome.php 42.42% <100%> (+42.42%) 8 <0> (ø) ⬇️
lib/private/Repair.php 79.76% <100%> (+53.57%) 21 <1> (ø) ⬇️
core/Command/Maintenance/Repair.php 90.51% <94.8%> (+90.51%) 29 <8> (+10) ⬆️
apps/encryption/templates/settings-admin.php 88.23% <0%> (-5.89%) 0% <0%> (ø)
lib/private/Server.php 84.75% <0%> (+0.26%) 129% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 98.06% <0%> (+1.16%) 51% <0%> (ø) ⬇️
lib/private/AllConfig.php 94.52% <0%> (+1.36%) 43% <0%> (ø) ⬇️
lib/private/Repair/RepairUnmergedShares.php 32.52% <0%> (+1.62%) 40% <0%> (ø) ⬇️
lib/private/Repair/RepairMimeTypes.php 88.59% <0%> (+1.75%) 47% <0%> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcdad1...3c5565e. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davitol
Copy link
Contributor

davitol commented May 16, 2019

* only `--list` option run if the server is not in maintenance mode.

Screen Shot 2019-05-16 at 13 25 31

Tested in oC 10.0.2. RC4, --list option is run even in maintenance mode

@karakayasemi jfyi

@karakayasemi
Copy link
Contributor Author

#29830 (comment) yes, I considered it as a desired behavior.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants