Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move oc-backbone-webdav loading to core #32184

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Conversation

PVince81
Copy link
Contributor

Description

Because other apps like files_versions need it but only worked because
it was indirectly loaded by the comments app.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test that comments app still works: can post a message
  • test that versions app works when comments app is disabled: panel appears

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added => not possible to test loading order
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Because other apps like files_versions need it but only worked because
it was indirectly loaded by the comments app.
@codecov
Copy link

codecov bot commented Jul 27, 2018

Codecov Report

Merging #32184 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #32184      +/-   ##
============================================
+ Coverage     63.96%   63.96%   +<.01%     
  Complexity    18595    18595              
============================================
  Files          1172     1172              
  Lines         69822    69822              
  Branches       1267     1267              
============================================
+ Hits          44659    44660       +1     
+ Misses        24794    24793       -1     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.81% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.23% <100%> (ø) 18595 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/comments/appinfo/app.php 16% <ø> (+0.61%) 0 <0> (ø) ⬇️
lib/private/legacy/template.php 52.14% <100%> (+0.29%) 40 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59c3156...0e0ecfc. Read the comment docs.

Copy link
Contributor

@felixheidecke felixheidecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the code but it looks good from a code perspective.

@PVince81 PVince81 merged commit 0aadf19 into master Aug 1, 2018
@PVince81 PVince81 deleted the js-loadbackboneincore branch August 1, 2018 09:42
@phil-davis
Copy link
Contributor

Backport stable10 #32208

@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[10.0.9] Disabling comments breaks files_versions
4 participants