Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership share fix stable10 #31952

Closed
wants to merge 2,614 commits into from

Conversation

sharidas
Copy link
Contributor

Description

This PR is a backport from PR: #31924

Related Issue

#31150

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

DeepDiver1975 and others added 30 commits June 5, 2018 12:59
…hId-gherkin-format-fix

[stable10] userCancelsUploadWithId gherkin format fix
Mock the EventDispatcher instead of creating new instance
and listening to events. The disptach arguments are taken
care while mocking.

Signed-off-by: Sujith H <[email protected]>
…-userpreferences

[stable10] Mock EventDispatcher instead of creating and listening events
…ptance-test-rework

[stable10] Provide summarized acceptance test chunking upload steps
[stable10] Add provisioning API disableApp feature
…e creation (#31569)

* Validate maximum length of a username before creation
* Add test for username maximum length validation
…f79831b71a68a28dc553

[stable10] Fixes #31568 - Validate maximum length of a username befor…
[stable10] Handle enable-disable of apps in acceptance tests
[Stable10] Add a new admin section for Imprint and Privacy Policy settings
…o-drone-phil

[stable10] Add caldav test to drone
[stable10] Fix apiVersion type and createShare call parameters
[stable10] Change lost password email to use separate templates for HTML and plain text
- Reusing the "oc_share.accepted" field to store share states.
- Added checkbox in settings page to enable automatically accepting
shares, this defaults to enabled currently. Unchecking this option will
prompt users to accept or reject shares through notifications
- Added pending and rejected shares in the "Shared with you" view
- The "unshare from self" action now changes the state of shares to
"Rejected" instead of deleting directly

Introduce updateShareForRecipient methods

- New method updateShareForRecipient on share manager and default share
provider to update both "files_target" and "accepted" fields.
- Rewired moveShare and updateShareForRecipient to use
updateShareForRecipient.
- Moved most of the validation code to the share provider

Migrate oc_share.permissions zero to accepted field

Added migration that sets oc_share.accepted to 2 (rejected) for all
sub-share entries that had oc_share.permissions=0.

The zero permissions is left there to avoid expensive migration and is
now gracefully ignored by the current code.
Improve visual share status (icons)
Shared with you can now be sorted by share state In that order: accepted, pending, rejected and then by file name.

Better error handling when switching share state

Pending share support for multiple received shares

Whenever multiple shares for the same node are received
through different, the accept/reject endpoint now properly
sets the state for all related shares.

Make pending shares unclickable

Exclude share owner and initiatior from notifications

Hack to make share file lists reload properly

Fixes issue with Firefox soft reload due to hidden field keeping its
value.

Deduplicate share target directly when accepting share

Solves issue where the order in which the deduplication is done in the
mount provider doesn't always match the accepting order

Resolve private link for shared with you

Sharing's notification publisher now rely on symfony event

Notification is sent on share.afterCreate and discarded on
share.afterDelete

Share object is now passed through share creation event so no need to
get it.

Remove notification on auto accept
remove class .disable-click; .share-state-rejected handles the job

Default cursor for folder and sharer in pending state
better xpath for finding file on Trashbin

use better behat steps in tests

API test to reaccept shares

enable apps via APPS_TO_ENABLE in api test script

UI tests to check notifications

API tests to check notifications

check notifications with regular expressions

enable auto_accept_share between tests

api tests for Discard notification if target user is not member of the group anymore

test notification link redirection
Remove the notification once an action has been taken

Remote shares will keep the old behaviour
run sharing notifications tests
enable notifications app
Fix retarget problem after accept / decline the share

Fix deduplication logic and add tests for it

Fix icon url for non-root ownCloud servers

Code style fixes and adjust acceptance test

Remove summary when the filelist is destroyed
only source file if its availiable

notifications do show users display name, fix expectations in tests
phil-davis and others added 17 commits June 28, 2018 10:39
…ssert

[stable10] User Management UI tests
[stable10] generated resource routes should allow slashes
The encryption keys were not deleted even after
files were deleted from the file system. The
reason for this is because of the wrong path
shared. Instead of filename, the relative path
from the files should be shared.

Signed-off-by: Sujith H <[email protected]>
…ses-in-urlparams

Revert "[stable10] generated resource routes should allow slashes"
…able10

[stable10] Cleanup the encryption keys after file deletion
…y-trashbin-stable10

Revert "[stable10] Cleanup the encryption keys after file deletion"
…stable10

[stable10] Adjustments for the notifications messages of the sharing apps
…866504d2d457209b2863

[stable10] Move AccountCheckException to public api
The child shares are transferred first before deleting
the parent share. If this is not done, then the child
shares are lost, which could result in loss of shares.

Signed-off-by: Sujith H <[email protected]>
@sharidas sharidas closed this Jun 29, 2018
@sharidas sharidas deleted the transfer-ownership-share-fix-stable10 branch June 29, 2018 15:17
@sharidas sharidas restored the transfer-ownership-share-fix-stable10 branch June 29, 2018 15:17
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.