Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public link share in transfer ownership command #31585

Merged
merged 1 commit into from
May 30, 2018

Conversation

sharidas
Copy link
Contributor

The public link share wasn't updated in the command.
This resulted in failure, when the public links were
accessed after the files were transferred. This change
helps to update the share for public links. And hence
access to the links won't cause any failure.

Signed-off-by: Sujith H [email protected]

Description

The public links were failing after transfer ownership command is executed.

Related Issue

#31150

Motivation and Context

This change allows the public links to work even after the transfer ownership command is executed.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sharidas sharidas self-assigned this May 30, 2018
@sharidas sharidas added this to the development milestone May 30, 2018
@sharidas
Copy link
Contributor Author

Backport of this PR: #31176 ( stable10 )

@sharidas sharidas force-pushed the master-fix-public-link-transferownership branch from 0d7f607 to aab9234 Compare May 30, 2018 07:59
@codecov
Copy link

codecov bot commented May 30, 2018

Codecov Report

Merging #31585 into master will increase coverage by 0.03%.
The diff coverage is 94.73%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31585      +/-   ##
============================================
+ Coverage     62.69%   62.72%   +0.03%     
- Complexity    18280    18292      +12     
============================================
  Files          1147     1148       +1     
  Lines         68647    68669      +22     
  Branches       1234     1234              
============================================
+ Hits          43041    43076      +35     
+ Misses        25245    25232      -13     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.94% <94.73%> (+0.03%) 18292 <18> (+12) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/TransferOwnership.php 0% <0%> (ø) 43 <0> (-6) ⬇️
lib/private/Server.php 85.09% <100%> (+0.01%) 250 <0> (ø) ⬇️
...ublic/Share/Exceptions/TransferSharesException.php 100% <100%> (ø) 1 <1> (?)
lib/private/Share20/Manager.php 97.24% <96.96%> (-0.02%) 231 <17> (+17)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 163efd2...166ec2a. Read the comment docs.

@sharidas sharidas force-pushed the master-fix-public-link-transferownership branch from aab9234 to ca4192c Compare May 30, 2018 08:43
The public link share wasn't updated in the command.
This resulted in failure, when the public links were
accessed after the files were transferred. This change
helps to update the share for public links. And hence
access to the links won't cause any failure.

Signed-off-by: Sujith H <[email protected]>
@sharidas sharidas force-pushed the master-fix-public-link-transferownership branch from ca4192c to 166ec2a Compare May 30, 2018 09:35
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit f4c5296 into master May 30, 2018
@PVince81 PVince81 deleted the master-fix-public-link-transferownership branch May 30, 2018 10:44
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants