Move select2 lib to core #31498
Move select2 lib to core #31498
Conversation
felixheidecke
added
Type:Bug
3 - To Review
p2-high
| @@ -28,10 +28,6 @@ | |||
| $eventDispatcher->addListener( | |||
| 'OCA\Files::loadAdditionalScripts', | |||
| function () { | |||
| // FIXME: no public API for these ? | |||
| \OC_Util::addVendorScript('select2/select2'); | |||
| \OC_Util::addVendorStyle('select2/select2'); | |||
There was a problem hiding this comment.
It was already there
Codecov Report
@@ Coverage Diff @@
## master #31498 +/- ##
============================================
+ Coverage 62.61% 62.61% +<.01%
Complexity 18273 18273
============================================
Files 1147 1147
Lines 68628 68627 -1
Branches 1234 1234
============================================
+ Hits 42970 42971 +1
+ Misses 25297 25295 -2
Partials 361 361
Continue to review full report at Codecov.
|
| @@ -132,6 +132,7 @@ public static function initTemplateEngine($renderAs) { | |||
|
|
|||
| OC_Util::addScript('oc-backbone', null, true); | |||
| OC_Util::addVendorScript('core', 'backbone/backbone', true); | |||
| OC_Util::addVendorScript('core', 'select2/select2', true); | |||
There was a problem hiding this comment.
did you miss adding the style as well or did it magically worked for some strange reasons ?
There was a problem hiding this comment.
seems it's already here: https://github.com/owncloud/core/pull/31498/files#diff-f7a9bb6da381ad3d1651acb5f47162a1R115
please move it down here for better readability
felixheidecke
force-pushed
the
move-select2-to-core
branch
from
bcd0678
to
0863f3a
Compare
|
Backport: #31581 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Move the select2 js library from systemtags app to core for global usage.
Related Issue
Fixes: #31338
How Has This Been Tested?
Manual tests
Screenshots (if appropriate):
Types of changes
Checklist: