Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The example theme now lives in https://github.com/owncloud/theme-example #31208

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

fixes #31206

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 19, 2018

Codecov Report

Merging #31208 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31208      +/-   ##
============================================
+ Coverage     62.54%   62.56%   +0.02%     
+ Complexity    18263    18247      -16     
============================================
  Files          1146     1145       -1     
  Lines         68443    68407      -36     
  Branches       1234     1234              
============================================
- Hits          42808    42801       -7     
+ Misses        25274    25245      -29     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.76% <ø> (+0.02%) 18247 <ø> (-16) ⬇️
Impacted Files Coverage Δ Complexity Δ
settings/Controller/AppSettingsController.php 78.94% <0%> (-7.02%) 29% <0%> (ø)
core/Command/App/ListApps.php 90.38% <0%> (-5.77%) 18% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23eea00...31ebbd8. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit c53f8ff into master Apr 20, 2018
@PVince81 PVince81 deleted the move-example-theme-to-repo branch April 20, 2018 07:50
@PVince81
Copy link
Contributor

please backport after #31206 (comment) was clarified

@phil-davis
Copy link
Contributor

Backport stable10 #31447

From the comments in the issue, I think the backport is valid.

@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new repo for theme-example
4 participants