Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version on public API #31055

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Fix version on public API #31055

merged 1 commit into from
Apr 20, 2018

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 9, 2018

Description

Adjusting since tag for all code related to objectstore and dav versions

Related Issue

#31050

Motivation and Context

API versions should be proper ....

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the development milestone Apr 9, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Apr 9, 2018
@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #31055 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #31055      +/-   ##
============================================
+ Coverage     62.45%   62.45%   +<.01%     
  Complexity    18230    18230              
============================================
  Files          1145     1145              
  Lines         68276    68276              
  Branches       1234     1234              
============================================
+ Hits          42641    42642       +1     
+ Misses        25274    25273       -1     
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.64% <ø> (ø) 18230 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8862fe3...57fa677. Read the comment docs.

@felixboehm felixboehm modified the milestones: development, planned Apr 10, 2018
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 5747258 into master Apr 20, 2018
@PVince81 PVince81 deleted the fix-version-on-public-api branch April 20, 2018 07:53
@PVince81 PVince81 modified the milestones: development, QA Jun 13, 2018
@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants