Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #3095 #3096

Merged
merged 2 commits into from
Apr 24, 2013
Merged

Fixing #3095 #3096

merged 2 commits into from
Apr 24, 2013

Conversation

Niduroki
Copy link
Member

Add missing space before newly created groups to fix #3095.

cc @jancborchardt @Raydiation @raghunayyar @tanghus @kabum

@tanghus
Copy link
Contributor

tanghus commented Apr 23, 2013

Works OK on FF +1

@MorrisJobke
Copy link
Contributor

Isn't it better to handle this with CSS?

@Niduroki
Copy link
Member Author

@kabum had to find out where the space around the multiselect options was coming from in the first place …
Stupid newlines :c

Better with css indeed.

@MorrisJobke
Copy link
Contributor

could you have a look at the checkboxes at add some left space
Chromium 26
Bildschirmfoto von 2013-04-24 11:28:00
Firefox 20
Bildschirmfoto von 2013-04-24 11:28:45

@MorrisJobke
Copy link
Contributor

👍

1 similar comment
@raghunayyar
Copy link
Member

👍

@raghunayyar raghunayyar merged commit 063e123 into master Apr 24, 2013
@raghunayyar raghunayyar deleted the add_missing_space_for_new_groups branch April 24, 2013 16:33
@lock lock bot locked as resolved and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ownCloud 5.0.5: Groups missing a space when added
4 participants