Add symfony event for resolving private links by apps #30795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apps can now resolve private links whenever the link was not resolvable by the files app. Currently only the trashbin is responding to this in case a file is in trash.
19 tasks
|
Wow, seems that little change broke a lot of tests... |
PVince81
force-pushed
the
privatelink-resolve-dispatcher
branch
from
7c70e29
to
18b20de
Compare
Codecov Report
@@ Coverage Diff @@
## master #30795 +/- ##
============================================
+ Coverage 61.97% 61.99% +0.01%
- Complexity 18358 18378 +20
============================================
Files 1157 1157
Lines 69066 69117 +51
Branches 1242 1242
============================================
+ Hits 42805 42848 +43
- Misses 25889 25897 +8
Partials 372 372
Continue to review full report at Codecov.
|
|
Ok so I found a way to make invokePrivate work for both static and non-static methods! |
DeepDiver1975
approved these changes
Mar 26, 2018
| $file = current($files); | ||
| if ($file instanceof Folder) { | ||
| // set the full path to enter the folder | ||
| $params['dir'] = $baseFolder->getRelativePath($file->getPath()); |
There was a problem hiding this comment.
Can throw NotFoundException? Add a general purpose try catch?
There was a problem hiding this comment.
Ok - never gets there ...
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apps can now resolve private links whenever the link was not resolvable by the files app.
Currently only the trashbin is responding to this in case a file is in trash.
Related Issue
Will be required for #30106 to also resolve file id to pending share page URL
Motivation and Context
Will be required for #30106 to also resolve file id to pending share page URL.
Also decouples the ViewController from trashbin...
How Has This Been Tested?
Manual test by opening a private link pointing at a trashed folder: the web UI opens in the trashed folder.
Unit tests.
Screenshots (if appropriate):
Types of changes
Checklist: