Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.sample.php #30400

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Update config.sample.php #30400

merged 1 commit into from
Feb 8, 2018

Conversation

cdamken
Copy link
Contributor

@cdamken cdamken commented Feb 7, 2018

Removing the old apps store from config.sample.php

* to that folder, starting from the ownCloud webroot. The key ``writable``
* indicates if a Web server can write files to that folder.
*/
'apps_paths' =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this one? We better adjust the documentation and not name the app store - but the config option itself is still falid

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, then we can just remove the other part

@codecov
Copy link

codecov bot commented Feb 7, 2018

Codecov Report

Merging #30400 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #30400      +/-   ##
============================================
+ Coverage     60.87%   60.88%   +<.01%     
+ Complexity    18568    18567       -1     
============================================
  Files          1093     1093              
  Lines         61325    61324       -1     
============================================
+ Hits          37333    37335       +2     
+ Misses        23992    23989       -3
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 82.84% <0%> (+0.14%) 129% <0%> (ø) ⬇️
lib/private/User/Session.php 58.91% <0%> (+0.15%) 139% <0%> (-1%) ⬇️
lib/private/Files/Cache/Propagator.php 98.7% <0%> (+1.29%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a6ec7d...5ed66dc. Read the comment docs.

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants