Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add share index #29864

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Add share index #29864

merged 1 commit into from
Dec 18, 2017

Conversation

tomneedham
Copy link
Contributor

@tomneedham tomneedham commented Dec 15, 2017

Description

SELECT `share_with` FROM `oc_share` WHERE `item_source` = 'fileid' AND `share_type` = '3' AND `item_type` IN ('file', 'folder') LIMIT 1;

becomes an expensive query when there are lots of shares in the table.

Motivation and Context

Less DB load, faster queries.

How Has This Been Tested?

Locally installation and sharing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the development milestone Dec 15, 2017
@tomneedham tomneedham self-assigned this Dec 15, 2017
@codecov
Copy link

codecov bot commented Dec 15, 2017

Codecov Report

Merging #29864 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29864      +/-   ##
============================================
+ Coverage     60.51%   60.51%   +<.01%     
- Complexity    18374    18382       +8     
============================================
  Files          1090     1091       +1     
  Lines         60933    60954      +21     
============================================
+ Hits          36874    36888      +14     
- Misses        24059    24066       +7
Impacted Files Coverage Δ Complexity Δ
...aring/appinfo/Migrations/Version20171215103657.php 0% <0%> (ø) 2 <2> (?)
lib/private/User/Manager.php 76.02% <0%> (+0.26%) 60% <0%> (+1%) ⬆️
lib/private/legacy/template.php 44.65% <0%> (+0.7%) 39% <0%> (+1%) ⬆️
lib/private/Template/Base.php 73.58% <0%> (+2.47%) 17% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce4a3a...fa33cd9. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 554f606 into master Dec 18, 2017
@DeepDiver1975 DeepDiver1975 deleted the share-index branch December 18, 2017 10:27
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants