Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/29087 behat for recovering #29488

Closed
wants to merge 5 commits into from
Closed

Feature/29087 behat for recovering #29488

wants to merge 5 commits into from

Conversation

peterprochaska
Copy link
Contributor

Description

New Behat Test for versioning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@peterprochaska peterprochaska added this to the development milestone Nov 7, 2017
@peterprochaska peterprochaska self-assigned this Nov 7, 2017
@DeepDiver1975
Copy link
Member

FYI: This PR is for reviewing and testing the last two commits

@DeepDiver1975 DeepDiver1975 mentioned this pull request Nov 8, 2017
Merged
9 tasks
@PVince81 PVince81 modified the milestones: development, planned Nov 8, 2017
@DeepDiver1975
Copy link
Member

@Peter-Prochaska please rebase

@DeepDiver1975 @peterprochaska
Add Content-Disposition header to GET responses of versions
bca2549 
Allow decryption of versions when being accessed by getContentOfVersion()

behat test for restoring a file

behat test for restoring a file
@codecov
Copy link

codecov bot commented Nov 14, 2017 •
edited
Loading

Codecov Report

Merging #29488 into master will increase coverage by 0.04%.
The diff coverage is 51.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #29488      +/-   ##
============================================
+ Coverage     61.63%   61.67%   +0.04%     
- Complexity    17477    17492      +15     
============================================
  Files          1044     1042       -2     
  Lines         57691    57684       -7     
============================================
+ Hits          35555    35576      +21     
+ Misses        22136    22108      -28
Impacted Files Coverage Δ Complexity Δ
apps/files_versions/appinfo/routes.php 75% <ø> (-15%) 0 <0> (ø)
apps/dav/lib/Connector/Sabre/Node.php 75% <ø> (ø) 49 <0> (ø) ⬇️
lib/private/Files/Storage/Wrapper/Encryption.php 66.99% <0%> (-0.83%) 156 <2> (+2)
apps/dav/lib/Meta/RootCollection.php 30.76% <0%> (-5.6%) 6 <0> (+1)
apps/dav/lib/Meta/MetaFile.php 0% <0%> (ø) 11 <4> (+4) ⬆️
apps/dav/lib/Meta/MetaFolder.php 0% <0%> (ø) 7 <3> (ø) ⬇️
lib/private/Files/Storage/Common.php 80.79% <100%> (+0.12%) 133 <0> (ø) ⬇️
lib/private/Files/Meta/MetaVersionCollection.php 71.42% <100%> (-1.55%) 12 <1> (-2)
apps/dav/lib/Connector/Sabre/Server.php 100% <100%> (ø) 1 <0> (ø) ⬇️
lib/private/Files/Meta/MetaFileVersionNode.php 81.81% <20%> (+11.81%) 16 <1> (+1) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36fbfc6...bca2549. Read the comment docs.

@DeepDiver1975 DeepDiver1975 mentioned this pull request Nov 20, 2017
Merged
9 tasks
@DeepDiver1975
Copy link
Member

continued in #29637

@DeepDiver1975 DeepDiver1975 deleted the feature/29087-behat-backup branch November 20, 2017 20:47
@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 Awaiting requested review from PVince81

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

Assignees

@peterprochaska peterprochaska

Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.8
Development

Successfully merging this pull request may close these issues.
4 participants
@peterprochaska @DeepDiver1975 @PVince81 @ownclouders