Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Fix the missing argument to DecryptAll #29371

Merged
merged 1 commit into from
Oct 27, 2017

Conversation

sharidas
Copy link
Contributor

logger is the last argument to DecryptAll which
was missing when DecryptAll is called. This change
fixes the same.

Signed-off-by: Sujith H [email protected]

Description

This change will fix the argument missing for DecryptAll called from recreate masterkey command

Related Issue

Motivation and Context

This issue solves the failure to run the command recreate masterkey due to missing argument for DecryptAll.

How Has This Been Tested?

  • Try to enable masterkey encryption
  • Run the recreate masterkey command

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

logger is the last argument to DecryptAll which
was missing when DecryptAll is called. This change
fixes the same.

Signed-off-by: Sujith H <[email protected]>
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Oct 27, 2017

Codecov Report

Merging #29371 into stable10 will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #29371   +/-   ##
===========================================
  Coverage       59.03%   59.03%           
  Complexity      17723    17723           
===========================================
  Files            1060     1060           
  Lines           59411    59411           
===========================================
  Hits            35075    35075           
  Misses          24336    24336
Impacted Files Coverage Δ Complexity Δ
apps/encryption/lib/Command/RecreateMasterKey.php 0% <0%> (ø) 10 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4517cb...12f8ca7. Read the comment docs.

@PVince81 PVince81 merged commit 2b6f6ca into stable10 Oct 27, 2017
@PVince81 PVince81 deleted the fix-decryptall-missingarg-stable10 branch October 27, 2017 12:42
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants