Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stable10] Register type mappings on createSchema invocation too #29268

Merged
merged 2 commits into from
Oct 19, 2017

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Oct 17, 2017

Description

Backport of #29263

Related Issue

Fixes #29262

See #29263 for details

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

2 - Developing, do you intend to do changes that weren't on master ?

@VicDeo
Copy link
Member Author

VicDeo commented Oct 17, 2017

@PVince81 nothing changed, I just have no time to test it right now.

@VicDeo
Copy link
Member Author

VicDeo commented Oct 17, 2017

@PVince81 tested, works, but CI is stalled.

@codecov
Copy link

codecov bot commented Oct 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (stable10@b8ce510). Click here to learn what that means.
The diff coverage is 31.03%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #29268   +/-   ##
===========================================
  Coverage            ?   58.48%           
  Complexity          ?    17676           
===========================================
  Files               ?     1058           
  Lines               ?    59243           
  Branches            ?        0           
===========================================
  Hits                ?    34649           
  Misses              ?    24594           
  Partials            ?        0
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/OracleMigrator.php 0% <ø> (ø) 10 <0> (?)
lib/private/DB/MySQLMigrator.php 0% <0%> (ø) 7 <4> (?)
lib/private/DB/MDB2SchemaManager.php 80.7% <0%> (ø) 17 <0> (?)
lib/private/DB/SQLiteMigrator.php 100% <100%> (ø) 7 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ce510...956a1a7. Read the comment docs.

@VicDeo
Copy link
Member Author

VicDeo commented Oct 18, 2017

rebased for CI

@VicDeo
Copy link
Member Author

VicDeo commented Oct 18, 2017

no way: '[ERROR] Waited 600 seconds, no response'

@DeepDiver1975 DeepDiver1975 merged commit ef290c2 into stable10 Oct 19, 2017
@DeepDiver1975 DeepDiver1975 deleted the stable10-fix-29262 branch October 19, 2017 17:42
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants