-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose XHR response in share dialog autocomplete callback #29223
Conversation
This makes it possible for apps that override the handler to have access to the actual response and also exact matches.
Required for owncloud/guests#168 |
I guess sending just the result would cause some breakage in other apps... |
@jvillafanez yes, the callback is actually expected to only receive the result that was prepared for display, so we cannot change that. This is why I chose to have it as a second argument. |
Let's say the response is additional info. |
JS tests passed and so did UI tests, merging |
stable10: #29231 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This makes it possible for apps that override the handler to have access
to the actual response and also exact matches.
Related Issue
N/A
Motivation and Context
How Has This Been Tested?
JS unit tests
Screenshots (if appropriate):
Types of changes
Checklist: