Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose XHR response in share dialog autocomplete callback #29223

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

PVince81
Copy link
Contributor

Description

This makes it possible for apps that override the handler to have access
to the actual response and also exact matches.

Related Issue

N/A

Motivation and Context

How Has This Been Tested?

JS unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This makes it possible for apps that override the handler to have access
to the actual response and also exact matches.
@PVince81
Copy link
Contributor Author

Required for owncloud/guests#168

@jvillafanez
Copy link
Member

I guess sending just the result would cause some breakage in other apps...

@PVince81
Copy link
Contributor Author

@jvillafanez yes, the callback is actually expected to only receive the result that was prepared for display, so we cannot change that. This is why I chose to have it as a second argument.

@jvillafanez
Copy link
Member

Let's say the response is additional info.

@PVince81
Copy link
Contributor Author

JS tests passed and so did UI tests, merging

@PVince81 PVince81 merged commit 8dde2c7 into master Oct 13, 2017
@PVince81 PVince81 deleted the sharedialog-autocomplete-expose-xhr-result branch October 13, 2017 07:43
@PVince81
Copy link
Contributor Author

stable10: #29231

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants