Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Federated Cloud Sharing info icon format #28965

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Federated Cloud Sharing info icon format #28965

merged 1 commit into from
Sep 11, 2017

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 10, 2017 •
edited by davitol
Loading

Description

Use the same classes etc. that other templates use to show the info icon on the same line after the heading text.

Related Issue

#28936

Motivation and Context

Make the UI consistent.

How Has This Been Tested?

View the result.

Screenshots (if appropriate):

federated-cloud-sharing-info-icon-2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Sep 10, 2017
@phil-davis phil-davis self-assigned this Sep 10, 2017
@phil-davis
Copy link
Contributor Author

Just a little UI format thing that I noticed while using the sharing settings page.

PVince81
PVince81 approved these changes Sep 11, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit f15453f into master Sep 11, 2017
@PVince81 PVince81 deleted the fed-cloud-sharing-info-icon branch September 11, 2017 08:35
@PVince81
Copy link
Contributor

backport?

@davitol
Copy link
Contributor

davitol commented Sep 11, 2017

backport?

It works fine in stable10 so it is no need to backport it

@PVince81
Copy link
Contributor

hmm, so what broke it on master ? In general I expected stable10 to be almost exactly the same as master, except for the new 10.0.4 additions.

@phil-davis phil-davis mentioned this pull request Sep 11, 2017
Merged
@phil-davis
Copy link
Contributor Author

It is broken for me in stable10

Backport stable10 #28972

@davitol
Copy link
Contributor

davitol commented Sep 11, 2017 •
edited
Loading

@phil-davis @PVince81 You were right, it is broken in stable10 too. I checked in a too old version. Sorry for the noise

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@tomneedham tomneedham Awaiting requested review from tomneedham

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

@davitol davitol Awaiting requested review from davitol

Assignees

@phil-davis phil-davis

Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@phil-davis @PVince81 @davitol @ownclouders