Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tests, testing renaming a file/folder into .htaccess #28738

Conversation

individual-it
Copy link
Member

some additional UI tests

@@ -45,6 +45,13 @@ Feature: renameFiles
|Could not rename "data.zip"|
And the file "data.zip" should be listed

Scenario: Rename a file to a forbidden name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as the .htaccess case of the scenario at line 37?

@@ -44,6 +44,13 @@ Feature: renameFolders
|Could not rename "simple-folder"|
And the folder "simple-folder" should be listed

Scenario: Rename a folder to a forbidden name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this is already on the scenario at line 36?

@individual-it
Copy link
Member Author

true deleted the duplication. Maybe its good to keep the separate #28737 (comment)
If not merge the ones in master too

@phil-davis
Copy link
Contributor

So do you just want to make a separate scenario so that the scenario text is more accurate?
Because splitting this out will take a bit more run time.

Also, if you do it this way, you need to also delete the extra 'Could not rename "data.zip"' in the other scenarios.

@individual-it individual-it force-pushed the stable10-backport-htaccesstests branch from fb33f88 to eb1b4e5 Compare August 18, 2017 09:51
@individual-it
Copy link
Member Author

So do you just want to make a separate scenario so that the scenario text is more accurate?
Because splitting this out will take a bit more run time.

ether splitting here or merging in master

@PVince81 PVince81 merged commit a7df728 into stable10-newdav-rename-forbiddentarget Aug 18, 2017
@PVince81 PVince81 deleted the stable10-backport-htaccesstests branch August 18, 2017 12:34
@PVince81 PVince81 added this to the old milestone Jun 13, 2018
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants