-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI tests, testing renaming a file/folder into .htaccess #28738
UI tests, testing renaming a file/folder into .htaccess #28738
Conversation
@@ -45,6 +45,13 @@ Feature: renameFiles | |||
|Could not rename "data.zip"| | |||
And the file "data.zip" should be listed | |||
|
|||
Scenario: Rename a file to a forbidden name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same as the .htaccess case of the scenario at line 37?
@@ -44,6 +44,13 @@ Feature: renameFolders | |||
|Could not rename "simple-folder"| | |||
And the folder "simple-folder" should be listed | |||
|
|||
Scenario: Rename a folder to a forbidden name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this is already on the scenario at line 36?
true deleted the duplication. Maybe its good to keep the separate #28737 (comment) |
So do you just want to make a separate scenario so that the scenario text is more accurate? Also, if you do it this way, you need to also delete the extra 'Could not rename "data.zip"' in the other scenarios. |
fb33f88
to
eb1b4e5
Compare
ether splitting here or merging in master |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
some additional UI tests