Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fatal log level in occ log:manage #28680

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 15, 2017

Description

Add the "fatal" log level to the list of log levels that the occ log:manage command knows about.
And similar for LoggingHelper.

Related Issue

#28679

Motivation and Context

Make occ log:manage work with the same log levels as available in the UI.

How Has This Been Tested?

  1. Set log level to Fatal in the UI.
  2. occ log:manage and confirm it produces good output
  3. Use occ log:manage to change to another log level - make sure the UI shows the new level.
  4. Use occ log:manage to change to fatal log level - make sure the UI shows the fatal level.

Make some UI tests that set the logging level to "fatal" and confirm that they run.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81
Copy link
Contributor

This is the original PR: #18369

There is no mention of purposefully omitting "fatal", it was likely an oversight.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@phil-davis phil-davis merged commit 84f3663 into master Aug 15, 2017
@phil-davis phil-davis deleted the occ-log-manage-level branch August 15, 2017 08:07
@phil-davis
Copy link
Contributor Author

Backport stable10 #28683

@mmattel
Copy link
Contributor

mmattel commented Aug 16, 2017

@phil-davis @PVince81

'set the log level [debug, info, warning, error, fatal]' is not updated in
documentation https://github.com/owncloud/documentation/blob/94ffcbc41d85789a61a5fe5eda0cc717b8684f62/admin_manual/configuration/server/occ_command.rst

log:manage sets your logging backend, log level, and timezone. The defaults are owncloud, Warning, and UTC. Available options are:

--backend [owncloud, syslog, errorlog]
--level [debug, info, warning, error]

phil-davis added a commit to owncloud-archive/documentation that referenced this pull request Aug 16, 2017
@phil-davis
Copy link
Contributor Author

Doc update owncloud-archive/documentation#3310

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants