Properly set the status text in the ocs response for v2 calls #28570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeepDiver1975
force-pushed
the
fix-ocs-status-text-in-v2-using-ocscontroller
branch
from
6d2217b
to
6acdf9b
Compare
guruz
reviewed
Aug 3, 2017
| @@ -191,7 +191,7 @@ public function testStatusCodeMapping() { | |||
| $this->createMock(ISecureRandom::class), | |||
| $configMock | |||
| )); | |||
| $expected = '{"ocs":{"meta":{"status":"failure","statuscode":200,"message":"OK",' . | |||
There was a problem hiding this comment.
heh even the test had this crazyness? :)
guruz
approved these changes
Aug 3, 2017
|
Looks slightly risky. If this is a regression, what introduced it and when ? |
This regression was introduced with the move-ocs-to-appframework change. It exists since the very first day. But we can also ignore this - nobody with a reasonable client should evaluate that status string |
|
Thanks for the explanation. I agree to merge this then. |
|
@DeepDiver1975 please backport to stable10. Backport further if older versions are affected too. |
This was referenced Aug 7, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For OCS v2 calls the status text for status 200 has to be 'ok' not failure
Related Issue
fixes owncloud/notifications#103
How Has This Been Tested?
Observe OCS responses in the notifications app
Types of changes
Checklist: