Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column lengths on migrations table to fix index #28086

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

tomneedham
Copy link
Contributor

Description

Reduces the lengths of the app and version columns in the migrations table so that the index that is created is not too long when using 4 byte database encodings and you have strict mode enabled.

Altered the create table method to use the new lengths (for new installs) and added a migration step to alter the existing table if it is already created (on upgrades)

Related Issue

Install is blocked when using 4 byte support with strict mode enabled.
#28030

Motivation and Context

Broken installs.

How Has This Been Tested?

New installs. Upgrades. Strict mode. mb4 encoding with MySQL.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@tomneedham tomneedham added this to the 10.0.3 milestone Jun 6, 2017
@tomneedham tomneedham self-assigned this Jun 6, 2017
@PVince81 PVince81 merged commit 684518d into master Jun 21, 2017
@PVince81 PVince81 deleted the migration-col-length branch June 21, 2017 09:05
@PVince81
Copy link
Contributor

@tomneedham please backport to stable10.

I guess the auto-truncation logic (or whatever was discussed) for the account table and search params will be done in a separate PR ?

@PVince81 PVince81 modified the milestones: 10.1, 10.0.3 Jun 21, 2017
@tomneedham
Copy link
Contributor Author

@PVince81 see #28019 for oc_account_terms fixes

@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants