Checking for local external storage flag iff the method is local.

[noveens]

Fixes #27619

Description

Regression from #27590

Related Issue

#27619

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[noveens]

sorry for the silly mistake @PVince81 😛

[PVince81]

you could remove this completely, users are never allowed to setup local storages for security reasons

[noveens]

@PVince81 , done.

[PVince81]

Tested, works.

Please fix the unit tests:

19:35:53 1) OCA\Files_External\Tests\Controller\GlobalStoragesControllerTest::testAddStorageWithoutConfig
19:35:53 OCP\Files\External\Service\IStoragesService::createStorage('mount', '\OCA\Files_External\Lib\Storage\SMB', '\OCA\Files_External\Lib\Auth\...hanism', Array (), Array (), Array (), Array (), null) was not expected to be called.
19:35:53 
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/lib/Controller/StoragesController.php:115
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/lib/Controller/GlobalStoragesController.php:99
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/tests/Controller/StoragesControllerTest.php:160
19:35:53 
19:35:53 2) OCA\Files_External\Tests\Controller\UserStoragesControllerTest::testAddStorageWithoutConfig
19:35:53 OCP\Files\External\Service\IStoragesService::createStorage('mount', '\OCA\Files_External\Lib\Storage\SMB', '\OCA\Files_External\Lib\Auth\...hanism', Array (), Array (), null, null, null) was not expected to be called.
19:35:53 
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/lib/Controller/StoragesController.php:115
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/lib/Controller/UserStoragesController.php:129
19:35:53 /var/lib/jenkins/workspace/owncloud-core_core_PR-27621-QCHHOII2IVFMCUHAYJPIT6GBRSN6JJRAA5ZQSU6L5LKW7XNJQPCA@2/apps/files_external/tests/Controller/StoragesControllerTest.php:160

[noveens]

@PVince81 ,
I have updated the test, and the test requires the check condition here as well :
https://github.com/owncloud/core/pull/27621/files#diff-432f5e183c311067085bd0348a8191fcR131

[PVince81]

Tested, works 👍

Let's wait for CI now

[noveens]

@PVince81 ,
Jenkins passed 😃
Merge?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.