Do not load previews for unsupported mimes

[VicDeo]

Description

- As suggested, set response to 204 instead of 404 if there is no preview

• Pass supported mimetypes via oc_appconfig.core.enabledPreviewProviders and test mime against this list on js side.

Related Issue

Fixes #24216

Motivation and Context

#24216 (comment)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[VicDeo]

I'd skip loading unsupported previews completely but I haven't found a way to grab all available mimetypes at once yet :/

another option is to extend DAV response with
<oc:previewurl>urlToPreview</oc:previewurl>
and kill that funky construction part in js completely

But Trashbin is still using old non-dav endpoint (what about other apps(?))

cc @PVince81

[PVince81]

I think just returning 204 should be enough.

Now I wonder if mobile clients might break with this... @davivel

If yes, then let's add a special header or query param that only the web UI gives to get that 204 response.

[VicDeo]

ok, reverting my local miserable attempts to pass supported mimes via oc_appconfig.core

[DeepDiver1975]

404 is the status if a resource is not found. This is the correct behaviour in this case. 👎

[PVince81]

In this case the only solution I can think of is to pass the list of supported previews through config.php or other means (like the mimetype JS thing) and prevent the client to request the preview URLs when it is known to not have previews.

That or send back the icon instead of a preview. But this could break the expectation of mobile client.

[DeepDiver1975]

In this case the only solution I can think of is to pass the list of supported previews through config.php or other means (like the mimetype JS thing) and prevent the client to request the preview URLs when it is known to not have previews.

👍 this is the way it is already supposed to work

[PVince81]

@DeepDiver1975 it doesn't, because the web UI currently has no idea what preview types are supported. There used to be an attribute isPreviewSupported that was returned with the old ajax/list.php endpoint which we replaced by Webdav. Webdav doesn't have such attribute.

Well, we could maybe add that attribute in Webdav and call it "oc:preview-url". If set, the web UI uses it to fetch the preview. If not set, fetch the icon instead.

[VicDeo]

@DeepDiver1975 @PVince81 oook... Finally I've found how to make this lazy-registered stuff less lazy.
Is it better now?

[PVince81]

please revert

[PVince81]

Tested, works.

However you need to revert the error code to 404.

[VicDeo]

@PVince81 reverted

[PVince81]

👍

Let's hope you don't need to massage Jenkins again

[VicDeo]

@PVince81 Tests passed

[dercorn]

@VicDeo @PVince81 @DeepDiver1975 Excellent work! 👍

[PVince81]

Regression #27932

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.