Expose the needupgrade status

[kprovost]

During upgrades, before the DB migration is complete, the system is not
usable, but there's no way for monitoring systems to detect this.
Add the 'needupgrade' field to the status json so monitoring systems can
detect this.

[CLAassistant]

All committers have signed the CLA.

[mention-bot]

@kprovost, thanks for your PR! By analyzing the annotation information on this pull request, we identified @butonic, @MorrisJobke and @DeepDiver1975 to be potential reviewers

[PVince81]

Make sense. Not sure if it should be called "needupgrade" as someone not knowing it and seeing it might expect the value to mean "this is an old version and needs updating" while it only means "this instance's code is on the latest version but the upgrade routine needs to be run".

Should it be called "needsDbUpgrade" instead ?
I'd also prefer to not have the value visible at all instead of being false, basically only add it to the array when it's true.

CC @DeepDiver1975 @butonic

[DeepDiver1975]

I'd also prefer to not have the value visible at all instead of being false, basically only add it to the array when it's true.

👍

[DeepDiver1975]

Should it be called "needsDbUpgrade" instead ?

not sure - there is no need from my pov to add too much technical details. 'needsUpgrade' is enough I guess

[kprovost]

I have no objections to changing the name, but I think I'd prefer always displaying the value. That way monitoring scripts (or other users) can easily tell the difference between a version that supports the field and a version that does not.

It's JSON, so clients just end up ignoring unknown/unsupported fields anyway.

[PVince81]

Fine by me then.

Can you rename it to "needsDbUpgrade" ? Because if people see it set to false they might believe it's an outdated OC version

[kprovost]

Done in cf0f297. (Comment because I don't know if the push triggered notifications on GitHub).

[DeepDiver1975]

👍

[PVince81]

Added to feature list https://github.com/owncloud/core/wiki/ownCloud-9.2-Features

Thanks a lot!

[Emil-G]

With OC10 the original meaning is used, however the name is the new one.

If one clustered server does a markedplace app upgrade, the other servers goes into needsDbUpgrade mode. Perhaps misleading?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.