-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of ajax/getstoragestats.php #26070
Conversation
@PVince81, thanks for your PR! By analyzing the annotation information on this pull request, we identified @MorrisJobke, @DeepDiver1975 and @LukasReschke to be potential reviewers |
TODOS:
|
Hmmm, getting the storage quota from PROPFIND is trickier than I thought. For the current user "quota-used-bytes" only contains the wanted value when doing a PROPFIND on the "/" path. But for received shares, one would need to do a PROPFIND on the share root instead to get the quota value from there. But even then, that value is actually the same (apparently?) like the "oc:size" which is mostly "how much bytes used by the contents of this share". But what we want is the actual used bytes of the sharing user's whole storage. All this is only to be able to detect whether more than 98% storage is used to display a warnings. This was achieved by "usedSpacePercent". |
I'd be tempted to get rid of this notification and implement it differently as a notification, which is basically a quota notification that the user would receive not only in the web UI but also on other clients. |
|
8a206f2
to
5be778a
Compare
I have now removed the polling of the storage stats. I'd like to get rid of the message about "your storage is almost full" and replace it with a notification in the future. |
Retrieve the necessary information from the file list's current directory element which is fetched from Webdav.
5be778a
to
450c1a8
Compare
moving to backlog, no time for this and there are blockers |
still waiting for the notification when close to quota |
files app will eventually be replaced by Phoenix not much point cleaning up the old code |
Description
See #26067.
Retrieve the necessary information from the file list's current directory element which is fetched from Webdav.
Related Issue
#26067
Motivation and Context
Less code path and get the info from where it's already available.
Kill ajax endpoints.
How Has This Been Tested?
Open folder, check
FileList.dirInfo
in the console.Try uploading a file when there is not enough space left, no Webdav call made, warning appears.
Check that every 5 minutes a PROPFIND is made on the current folder and
FileList.dirInfo
contains the updated info.Types of changes
Checklist: