Contacts API: replace raw image data with url #25081
Conversation
|
By analyzing the blame information on this pull request, we identified @schiessle, @DeepDiver1975 and @nickvergessen to be potential reviewers |
georgehrke
force-pushed
the
dav_contacts_image_uri
branch
from
dafd43b to
e6d7a08
Compare
|
|
||
| return [ | ||
| 'routes' => [ | ||
| ['name' => 'photos#get', 'url' => '/contactsphoto/{addressbookId}/{contactUri}', 'verb' => 'GET'], |
There was a problem hiding this comment.
hmmm ... I would have built this as part of the webdav routes
please note there are only 2 public http based protocols we support: webdav and ocs api.
routes like above are considered private and should not be exposed to 3rdparty - the mail and contacts apps are treated as 3rdparty
There was a problem hiding this comment.
I'm not so sure about the webdav route, because this change only affects the PHP based Contacts API. Adding this to the WebDAV routes would require apps like the Mail app to implement a dav client just to fetch contact images 😕
There was a problem hiding this comment.
Adding this to the WebDAV routes would require apps like the Mail app to implement a dav client just to fetch contact images 😕
A GET is a GET is a GET .... 🙊
There was a problem hiding this comment.
A GET is a GET is a GET ....
Well, there is some truth to this 🙈
There was a problem hiding this comment.
Is there some "easy" straight forward way to register routes or do I need to write a plugin like in https://github.com/owncloud/core/blob/master/apps/dav/lib/Comments/CommentsPlugin.php#L86?
georgehrke
force-pushed
the
dav_contacts_image_uri
branch
from
e6d7a08 to
2858111
Compare
georgehrke
force-pushed
the
dav_contacts_image_uri
branch
2 times, most recently
from
37c6655 to
77399b8
Compare
| @@ -103,6 +104,7 @@ public function __construct(IRequest $request, $baseUri) { | |||
| // addressbook plugins | |||
| $this->server->addPlugin(new \OCA\DAV\CardDAV\Plugin()); | |||
| $this->server->addPlugin(new VCFExportPlugin()); | |||
| $this->server->addPlugin(new ImageExportPlugin()); | |||
There was a problem hiding this comment.
Must be added to the serverfactory as well for v1 routes
georgehrke
force-pushed
the
dav_contacts_image_uri
branch
from
2091112 to
2d23609
Compare
|
please review @DeepDiver1975 @ChristophWurst @PVince81 |
|
👍 nice, works! |
| use Sabre\VObject\Parameter; | ||
| use Sabre\VObject\Reader; | ||
|
|
||
| class ImageExportPlugin extends ServerPlugin { |
There was a problem hiding this comment.
this plugin deserves some unit tests as well 🙈
|
@ChristophWurst @Gomez did you test this with the mail app? does it work? THX |
|
Yeah works in Mail! Nice @georgehrke |
DeepDiver1975
force-pushed
the
dav_contacts_image_uri
branch
from
6aae6e9 to
72e0732
Compare
| // | ||
| // TODO: these three below are not working - needs debugging | ||
| // | ||
| // 'vcard 3 with PHOTO URL' => [['Content-Type' => 'image/jpeg', 'body' => '12345'], "BEGIN:VCARD\r\nVERSION:3.0\r\nPRODID:-//Sabre//Sabre VObject 3.5.0//EN\r\nUID:12345\r\nFN:12345\r\nN:12345;;;;\r\nPHOTO;TYPE=JPEG:http://example.org/photo.jpg\r\nEND:VCARD\r\n"], |
There was a problem hiding this comment.
@georgehrke mind debugging these 3 cases and adjust the code accordingly?
There was a problem hiding this comment.
Sure, I can take a look tomorrow
There was a problem hiding this comment.
How is http://example.org/photo.jpg supposed to return '12345' in the first place?
There was a problem hiding this comment.
anyway, 'vcard 3 with PHOTO URL' seems to be a bug in Sabre/Vobject because getValueType() returns BINARY
There was a problem hiding this comment.
'vcard 4 with PHOTO URL' is fixed now
There was a problem hiding this comment.
How is http://example.org/photo.jpg supposed to return '12345' in the first place?
it's not 🙈
There was a problem hiding this comment.
please file issues upstream - thx
There was a problem hiding this comment.
There was a problem hiding this comment.
done - fruux/sabre-vobject#325
THX
georgehrke
force-pushed
the
dav_contacts_image_uri
branch
from
72e0732 to
836def3
Compare
|
👍 |
|
Oooh this is awesome! :) Great work! Will it be backported as well? |
|
@georgehrke please prepare backport pr - we want to make oc9 users happy as well 🙈 |
|
sure |
|
stable9: #25219 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
fixes #23345