ldap group membership background job should also throw pre_addToGroup…

[blizzz]

…, because sharing listens to it. Fixes #21986.

Reason for this PR is #21854 (comment), however looking at the code, this hook should have been fired before. Nevertheless, sharing worked. Now I wonder whether this is really needed, but I still guess so.

As brief excursion: At some time in the past sharing listened to addToGroup and RemoveFromGroup hooks for updating the shares. Because with LDAP we do not when a member is added or removed from a group, we have a background job that updates the members and throws hooks, if necessary.

@schiesbn @MorrisJobke @rullzer what do you think?

[rullzer]

While I think this should all be fine. It is a bit weird from a semantic point of view. Because the group is already there. So if there is any logic that assumes the group is not that will fail.

[blizzz]

<Blizzz> BeS: i.e. #22664 is unnecessry?
<Blizzz> less code, better.
<BeS> Blizzz: yes, it is probably not unnecessry. But please double-check
<BeS> 1. share a file test.txt with a group
<BeS> 2. create a file text.txt for a user who is not in the group
<BeS> 3. add the user to the group
<BeS> 4 login as the user and check the the group share is mounted as test.txt (2)
<Blizzz> BeS: I will try this, thx.

→ Tested, works without this PR, thus closing.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.