Do not check all chunks of a chunked upload if we do not need to #22602
Conversation
|
By analyzing the blame information on this pull request, we identified @bartv2, @DeepDiver1975 and @PVince81 to be potential reviewers |
|
👍 |
rullzer
force-pushed
the
fix_slow_chunkcheck
branch
from
4d353ef to
47acc59
Compare
|
Please review @PVince81 @nickvergessen @DeepDiver1975 |
|
Set milestone to 9.1 as this PR is against master. |
|
To test, upload a 'large' file using the desktop client. |
|
Unit test would be nice, if possible, for consistent results. |
Fixes #22601 Before we did a full test on all chunks to verify if a chunked upload was completed. This is unneeded since if we are missing one chunk we can already fail. Also we look from back to front since it is much more likely that we find a missing chunk thus can error out early.
* Unit tests for OC_Filechunking to verify the isComplete function * Intergration tests to show that shuffling chunks is all fine
rullzer
force-pushed
the
fix_slow_chunkcheck
branch
from
47acc59 to
7301b43
Compare
|
@PVince81 some unit tests and intergration tests :) |
|
Looks better 👍 |
|
@karlitschek would be good to backport this to 9.0.1 since it helps with a blue ticket on the client side. (Issue is also against 9.0.1). |
|
Looks good 👍 |
|
backport makes sense 👍 |
|
stable9: #23022 |
Do not check all chunks of a chunked upload if we do not need to
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #22601
Before we did a full test on all chunks to verify if a chunked upload
was completed. This is unneeded since if we are missing one chunk we can
already fail.
Also we look from back to front since it is much more likely that we
find a missing chunk thus can error out early.
FYI: @dragotin @DeepDiver1975 @jturcotte @ogoffart
On my system this saves ~4 seconds on a 1GB upload. But the slower the storage the bigger the gain.