Comment owner can now edit or delete #22108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
PVince81
commented
Feb 3, 2016
PVince81
commented
- REQUIRES: Add file row indicator for unread comments #22101 to be merged first
- edit/delete functionality
- maybe move the delete action to edit mode (similar to system tags, seems to be a pattern that @jancborchardt might like)
- write unit tests
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975 and @MorrisJobke to be potential reviewers |
PVince81
force-pushed
the
comments-edit
branch
from
73e2624 to
805ba20
Compare
|
I decided to move the trash icon into edit mode. It clutters the UI less and also adds an additional click for deletion. Please review @blizzz @icewind1991 @rullzer @DeepDiver1975 @nickvergessen |
|
Pro thing: make the text input box resizable. Ain't there some magic class or so from jqueryui? Works in LDAP config. Otherwise: works as advertised 👍 |
|
Works 👍 |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 4, 2016
Comment owner can now edit or delete
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.