Add command to get and set config for external mounts #20710
Conversation
|
Woah, nice! (Will review in the next few days) |
|
@icewind1991 can you always post a link to the original ticket it is related to ? For #20368 |
|
Looks good 👍 |
| ->setName('files_external:config') | ||
| ->setDescription('Manage backend configuration for a mount') | ||
| ->addArgument( | ||
| 'action', |
There was a problem hiding this comment.
It would be cleaner to get if there is no value passed, and set if there is a value passed, removing the need for a separate command line argument.
Proposed example usage:
./occ files_external:config 42 host #prints 'localhost'
./occ files_external:config 42 host abc.example.com #sets host
There was a problem hiding this comment.
Seems cleaner yes
icewind1991
force-pushed
the
files_external_config_command
branch
from
219ac67 to
6ed4dcc
Compare
|
Removed the get/set argument, action is now determined based on if the value is defined |
|
Also added command to set mount options |
| $key = $input->getArgument('key'); | ||
| $mount = $this->globalService->getStorage($mountId); | ||
|
|
||
| if (!$mount instanceof StorageConfig) { |
There was a problem hiding this comment.
The storage service will throw an exception itself if the storage cannot be found, so this block is unneeded (but it might be advisable to wrap the getStorage() in a try catch to print a better message)
icewind1991
force-pushed
the
files_external_config_command
branch
from
e7efbe9 to
1e1cb7a
Compare
| $mount = $this->globalService->getStorage($mountId); | ||
| } catch (NotFoundException $e) { | ||
| $output->writeln('<error>Mount with id "' . $mountId . ' not found, check "occ files_external:list" to get available mounts"</error>'); | ||
| return; |
There was a problem hiding this comment.
Return with a non-zero code so shell scripts can detect the error
There was a problem hiding this comment.
@icewind1991 can you fix this and then I'll count @Xenopathic's LGTM as 👍
|
LGTM so far, just one question: how can we set non-string values, e.g. integers or booleans? |
|
You can just enter them directory, bools, ints and floats are all handled correctly |
|
@Xenopathic counts as 👍 ? |
|
@Xenopathic @DeepDiver1975 merge? |
icewind1991
force-pushed
the
files_external_config_command
branch
from
1e1cb7a to
1347e33
Compare
|
👍 |
Add command to get and set config for external mounts
Usage:
Currently this only works for admin configured storage due to limitations in the way we store mounts, with #20370 it can be extended to properly handle user configured mounts
cc @PVince81 @Xenopathic